[DebugInfoPDB] A few cleanups on PDB Variant class.

Also implements the PDBSymbolCompilandEnv::getValue() method,
which until now had been unimplemented specifically because
variant did not support string values.

llvm-svn: 261173

1 files changed, 2 insertions, 2 deletions

diff --git a/llvm/include/llvm/DebugInfo/PDB/PDBTypes.h b/llvm/include/llvm/DebugInfo/PDB/PDBTypes.h
index 77b98fb8574..adec27a357d 100644
--- a/llvm/include/llvm/DebugInfo/PDB/PDBTypes.h
+++ b/llvm/include/llvm/DebugInfo/PDB/PDBTypes.h
@@ -363,7 +363,7 @@ struct Variant {
   }
 
   ~Variant() {
-    if (Type == PDB_VariantType::String && Value.String != nullptr)
+    if (Type == PDB_VariantType::String)
       delete[] Value.String;
   }
 
@@ -410,7 +410,7 @@ struct Variant {
   Variant &operator=(const Variant &Other) {
     if (this == &Other)
       return *this;
-    if (Type == PDB_VariantType::String && Value.String != nullptr)
+    if (Type == PDB_VariantType::String)
       delete[] Value.String;
     Type = Other.Type;
     Value = Other.Value;