diff options
| author | Peter Collingbourne <peter@pcc.me.uk> | 2015-06-30 19:10:31 +0000 |
|---|---|---|
| committer | Peter Collingbourne <peter@pcc.me.uk> | 2015-06-30 19:10:31 +0000 |
| commit | 1feef2eb03c174081f702e4bf725e997a10d65c3 (patch) | |
| tree | 85a1c860441302811fac704e6a1657c3d2bc3f11 /llvm/docs | |
| parent | 45a2401c04f41789c09f4a48bc640042daa5786e (diff) | |
| download | bcm5719-llvm-1feef2eb03c174081f702e4bf725e997a10d65c3.tar.gz bcm5719-llvm-1feef2eb03c174081f702e4bf725e997a10d65c3.zip | |
COFF: Do not assign linker-weak symbols to selectany comdat sections.
It is mandatory to specify a comdat in order to receive comdat semantics
for a symbol. We were previously getting this wrong in -function-sections
mode; linker-weak symbols were being emitted in a selectany comdat. This
change causes such symbols to use a noduplicates comdat instead, fixing
the inconsistency.
Also correct an inaccuracy in the docs.
Differential Revision: http://reviews.llvm.org/D10828
llvm-svn: 241103
Diffstat (limited to 'llvm/docs')
| -rw-r--r-- | llvm/docs/LangRef.rst | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/llvm/docs/LangRef.rst b/llvm/docs/LangRef.rst index ef9fd92d2e5..c91b0ce621d 100644 --- a/llvm/docs/LangRef.rst +++ b/llvm/docs/LangRef.rst @@ -823,9 +823,11 @@ with the same name. This is necessary because both globals belong to different COMDAT groups and COMDATs, at the object file level, are represented by sections. -Note that certain IR constructs like global variables and functions may create -COMDATs in the object file in addition to any which are specified using COMDAT -IR. This arises, for example, when a global variable has linkonce_odr linkage. +Note that certain IR constructs like global variables and functions may +create COMDATs in the object file in addition to any which are specified using +COMDAT IR. This arises when the code generator is configured to emit globals +in individual sections (e.g. when `-data-sections` or `-function-sections` +is supplied to `llc`). .. _namedmetadatastructure: |

