diff options
| author | Matt Arsenault <Matthew.Arsenault@amd.com> | 2019-03-12 21:02:54 +0000 |
|---|---|---|
| committer | Matt Arsenault <Matthew.Arsenault@amd.com> | 2019-03-12 21:02:54 +0000 |
| commit | caf1316f7100e1ba1e7e800eae6a5adf0d48bf90 (patch) | |
| tree | 7b79b67ccf3ffe7fe9b56dee66444a586d7714d2 /llvm/docs/ReleaseNotes.rst | |
| parent | 9df0754b8dbeeb597a22bb0418eb0ee04ce88b56 (diff) | |
| download | bcm5719-llvm-caf1316f7100e1ba1e7e800eae6a5adf0d48bf90.tar.gz bcm5719-llvm-caf1316f7100e1ba1e7e800eae6a5adf0d48bf90.zip | |
IR: Add immarg attribute
This indicates an intrinsic parameter is required to be a constant,
and should not be replaced with a non-constant value.
Add the attribute to all AMDGPU and generic intrinsics that comments
indicate it should apply to. I scanned other target intrinsics, but I
don't see any obvious comments indicating which arguments are intended
to be only immediates.
This breaks one questionable testcase for the autoupgrade. I'm unclear
on whether the autoupgrade is supposed to really handle declarations
which were never valid. The verifier fails because the attributes now
refer to a parameter past the end of the argument list.
llvm-svn: 355981
Diffstat (limited to 'llvm/docs/ReleaseNotes.rst')
| -rw-r--r-- | llvm/docs/ReleaseNotes.rst | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/llvm/docs/ReleaseNotes.rst b/llvm/docs/ReleaseNotes.rst index ff116b65559..e0cebf508c4 100644 --- a/llvm/docs/ReleaseNotes.rst +++ b/llvm/docs/ReleaseNotes.rst @@ -58,6 +58,10 @@ Non-comprehensive list of changes in this release Changes to the LLVM IR ---------------------- +* Added ``immarg`` parameter attribute. This indicates an intrinsic + parameter is required to be a simple constant. This annotation must + be accurate to avoid possible miscompiles. + Changes to the ARM Backend -------------------------- |
