diff options
| author | Florian Hahn <florian.hahn@arm.com> | 2016-12-30 21:28:30 +0000 |
|---|---|---|
| committer | Florian Hahn <florian.hahn@arm.com> | 2016-12-30 21:28:30 +0000 |
| commit | e7407ba1ef07a6cc4f6456b5787e8237e4a91ccd (patch) | |
| tree | 706065665587c4063bb4b8f2a6c1ff1a46684e7f /llvm/docs/Phabricator.rst | |
| parent | 8ab17a30a2316c0ecc09341382fdc6959aa42418 (diff) | |
| download | bcm5719-llvm-e7407ba1ef07a6cc4f6456b5787e8237e4a91ccd.tar.gz bcm5719-llvm-e7407ba1ef07a6cc4f6456b5787e8237e4a91ccd.zip | |
[doc] Clarify steps for contributors without commit access.
Summary: Update the Phabricator docs to clarify how changes are merged for contributors without commit access.
Reviewers: delcypher, aaron.ballman
Subscribers: aaron.ballman, anmol, llvm-commits
Differential Revision: https://reviews.llvm.org/D28184
llvm-svn: 290767
Diffstat (limited to 'llvm/docs/Phabricator.rst')
| -rw-r--r-- | llvm/docs/Phabricator.rst | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/llvm/docs/Phabricator.rst b/llvm/docs/Phabricator.rst index 04319a9a378..06a9c6af9b4 100644 --- a/llvm/docs/Phabricator.rst +++ b/llvm/docs/Phabricator.rst @@ -128,8 +128,12 @@ Committing a change ------------------- Once a patch has been reviewed and approved on Phabricator it can then be -committed to trunk. There are multiple workflows to achieve this. Whichever -method you follow it is recommend that your commit message ends with the line: +committed to trunk. If you do not have commit access, someone has to +commit the change for you (with attribution). It is sufficient to add +a comment to the approved review indicating you cannot commit the patch +yourself. If you have commit access, there are multiple workflows to commit the +change. Whichever method you follow it is recommend that your commit message +ends with the line: :: |
