diff options
| author | Paul Robinson <paul_robinson@playstation.sony.com> | 2016-01-08 17:05:12 +0000 |
|---|---|---|
| committer | Paul Robinson <paul_robinson@playstation.sony.com> | 2016-01-08 17:05:12 +0000 |
| commit | d4db94846ad6c3db02d82dca0aa7af2df8296f20 (patch) | |
| tree | fce68a9decf627e8013e9dfb85bda52dec6d1d26 /llvm/docs/Phabricator.rst | |
| parent | 4b4f4b90ed42bd8de8a07db721128673a5f69b76 (diff) | |
| download | bcm5719-llvm-d4db94846ad6c3db02d82dca0aa7af2df8296f20.tar.gz bcm5719-llvm-d4db94846ad6c3db02d82dca0aa7af2df8296f20.zip | |
How to close a review manually.
llvm-svn: 257180
Diffstat (limited to 'llvm/docs/Phabricator.rst')
| -rw-r--r-- | llvm/docs/Phabricator.rst | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/llvm/docs/Phabricator.rst b/llvm/docs/Phabricator.rst index 73704d9b17d..af1e4429fda 100644 --- a/llvm/docs/Phabricator.rst +++ b/llvm/docs/Phabricator.rst @@ -136,7 +136,7 @@ reviewers, the ``Differential Revision``, etc from the review and commit it to t arc commit --revision D<Revision> -When committing an LLVM change that has been reviewed using +When committing a change that has been reviewed using Phabricator, the convention is for the commit message to end with the line: @@ -153,6 +153,12 @@ This allows people reading the version history to see the review for context. This also allows Phabricator to detect the commit, close the review, and add a link from the review to the commit. +If you use ``git`` or ``svn`` to commit the change and forget to add the line +to your commit message, you should close the review manually. In the web UI, +under "Leap Into Action" put the SVN revision number in the Comment, set the +Action to "Close Revision" and click Submit. Note the review must have been +Accepted first. + Abandoning a change ------------------- |
