diff options
author | Roman Lebedev <lebedev.ri@gmail.com> | 2017-09-19 21:11:35 +0000 |
---|---|---|
committer | Roman Lebedev <lebedev.ri@gmail.com> | 2017-09-19 21:11:35 +0000 |
commit | c9c9748d99e663cb98663f7fbc6ac0b30bd8fa16 (patch) | |
tree | ce21fbffe94832d4e00135015a5b48839cda7961 /llvm/docs/CoverageMappingFormat.rst | |
parent | 8cc8b63b0656b857eb9e9ce773529f29594d2ac1 (diff) | |
download | bcm5719-llvm-c9c9748d99e663cb98663f7fbc6ac0b30bd8fa16.tar.gz bcm5719-llvm-c9c9748d99e663cb98663f7fbc6ac0b30bd8fa16.zip |
[Sema] Move some stuff into -Wtautological-unsigned-enum-zero-compare
Summary:
As requested by Sam McCall:
> Enums (not new I guess). Typical case: if (enum < 0 || enum > MAX)
> The warning strongly suggests that the enum < 0 check has no effect
> (for enums with nonnegative ranges).
> Clang doesn't seem to optimize such checks out though, and they seem
> likely to catch bugs in some cases. Yes, only if there's UB elsewhere,
> but I assume not optimizing out these checks indicates a deliberate
> decision to stay somewhat compatible with a technically-incorrect
> mental model.
> If this is the case, should we move these to a
> -Wtautological-compare-enum subcategory?
Reviewers: rjmccall, rsmith, aaron.ballman, sammccall, bkramer, djasper
Reviewed By: aaron.ballman
Subscribers: jroelofs, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D37629
llvm-svn: 313677
Diffstat (limited to 'llvm/docs/CoverageMappingFormat.rst')
0 files changed, 0 insertions, 0 deletions