diff options
| author | Shoaib Meenai <smeenai@fb.com> | 2019-01-31 20:32:45 +0000 |
|---|---|---|
| committer | Shoaib Meenai <smeenai@fb.com> | 2019-01-31 20:32:45 +0000 |
| commit | e1b332efba12ce1d5a482084a5182e0527e9c88d (patch) | |
| tree | dc1af093e584590c40232379131474ec458b9238 /llvm/cmake | |
| parent | fc7faecb401c1ef50c8f71594aad16cb150eb987 (diff) | |
| download | bcm5719-llvm-e1b332efba12ce1d5a482084a5182e0527e9c88d.tar.gz bcm5719-llvm-e1b332efba12ce1d5a482084a5182e0527e9c88d.zip | |
[cmake] Note future cleanup in comment. NFC
CMake 3.6 introduced CMAKE_TRY_COMPILE_PLATFORM_VARIABLES, which solves
precisely the problem that necessitated init_user_prop, so we can switch
over whenever we bump our minimum CMake requirement.
llvm-svn: 352790
Diffstat (limited to 'llvm/cmake')
| -rw-r--r-- | llvm/cmake/platforms/WinMsvc.cmake | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/llvm/cmake/platforms/WinMsvc.cmake b/llvm/cmake/platforms/WinMsvc.cmake index f625d0e3c05..d038df97951 100644 --- a/llvm/cmake/platforms/WinMsvc.cmake +++ b/llvm/cmake/platforms/WinMsvc.cmake @@ -92,7 +92,9 @@ # won't see the value of any arguments the user passed via -D. Since these are # necessary to properly configure MSVC in both the top-level configuration as well as # all feature-test invocations, we set environment variables with the values so that -# these environments get inherited by child invocations. +# these environments get inherited by child invocations. We can switch to +# CMAKE_TRY_COMPILE_PLATFORM_VARIABLES once our minimum supported CMake version +# is 3.6 or greater. function(init_user_prop prop) if(${prop}) set(ENV{_${prop}} "${${prop}}") |
