diff options
| author | Chris Bieneman <chris.bieneman@me.com> | 2019-08-05 17:50:08 +0000 |
|---|---|---|
| committer | Chris Bieneman <chris.bieneman@me.com> | 2019-08-05 17:50:08 +0000 |
| commit | 3c0c6e5c50d64fe6b247373ff73edcbf46c337b6 (patch) | |
| tree | bb457bcdc471bc8ac824c1c9cc816cbb5d03d0c9 /llvm/cmake/modules | |
| parent | a8426b43f8b99217e564b21a9d7aef7871292b4c (diff) | |
| download | bcm5719-llvm-3c0c6e5c50d64fe6b247373ff73edcbf46c337b6.tar.gz bcm5719-llvm-3c0c6e5c50d64fe6b247373ff73edcbf46c337b6.zip | |
NATIVE tablegen needs to depend on target tablegen
This dependency was removed in r357486, which has lead to a stream of difficult to diagnose bugs.
Without this dependency, when building with `LLVM_OPTIMIZED_TABLEGEN=On` the native tablegen executible may not be rebuilt at all, and often won't get rebuilt before targets that use the tablegen headers. In the best case this results in a build-time failure, in the worst case it results in runtime failures.
llvm-svn: 367895
Diffstat (limited to 'llvm/cmake/modules')
| -rw-r--r-- | llvm/cmake/modules/TableGen.cmake | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/llvm/cmake/modules/TableGen.cmake b/llvm/cmake/modules/TableGen.cmake index 36c026b5c0f..23c8fd8a2ba 100644 --- a/llvm/cmake/modules/TableGen.cmake +++ b/llvm/cmake/modules/TableGen.cmake @@ -125,7 +125,7 @@ macro(add_tablegen target project) if(LLVM_USE_HOST_TOOLS) if( ${${project}_TABLEGEN} STREQUAL "${target}" ) - build_native_tool(${target} ${project}_TABLEGEN_EXE) + build_native_tool(${target} ${project}_TABLEGEN_EXE DEPENDS ${target}) set(${project}_TABLEGEN_EXE ${${project}_TABLEGEN_EXE} PARENT_SCOPE) add_custom_target(${project}-tablegen-host DEPENDS ${${project}_TABLEGEN_EXE}) |
