diff options
| author | Pavel Labath <pavel@labath.sk> | 2019-10-30 14:31:57 +0100 |
|---|---|---|
| committer | Pavel Labath <pavel@labath.sk> | 2019-10-30 14:46:00 +0100 |
| commit | 83a55c6a575806eec78062dfe128c095c26ab5e2 (patch) | |
| tree | 618225d195b706220bb5c2a085f76b6e59519bd3 /lldb | |
| parent | 74bb5ee67413db7e3e3351b7fde65db7e4568e02 (diff) | |
| download | bcm5719-llvm-83a55c6a575806eec78062dfe128c095c26ab5e2.tar.gz bcm5719-llvm-83a55c6a575806eec78062dfe128c095c26ab5e2.zip | |
minidump: Rename some architecture constants
The architecture enum contains two kinds of contstants: the "official" ones
defined by Microsoft, and unofficial constants added by breakpad to cover the
architectures not described by the first ones.
Up until now, there was no big need to differentiate between the two. However,
now that Microsoft has defined
https://docs.microsoft.com/en-us/windows/win32/api/sysinfoapi/ns-sysinfoapi-system_info
a constant for ARM64, we have a name clash.
This patch renames all breakpad-defined constants with to include the prefix
"BP_". This frees up the name "ARM64", which I'll re-introduce with the new
"official" value in a follow-up patch.
Reviewers: amccarth, clayborg
Subscribers: lldb-commits, llvm-commits
Differential Revision: https://reviews.llvm.org/D69285
Diffstat (limited to 'lldb')
5 files changed, 5 insertions, 5 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/arm64-macos.yaml b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/arm64-macos.yaml index 9114424e470..70817f14da5 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/arm64-macos.yaml +++ b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/arm64-macos.yaml @@ -1,7 +1,7 @@ --- !minidump Streams: - Type: SystemInfo - Processor Arch: ARM64 + Processor Arch: BP_ARM64 Platform ID: MacOSX CSD Version: '15E216' CPU: diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/regions-linux-map.yaml b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/regions-linux-map.yaml index 3c0961eba07..680ad623361 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/regions-linux-map.yaml +++ b/lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/regions-linux-map.yaml @@ -1,7 +1,7 @@ --- !minidump Streams: - Type: SystemInfo - Processor Arch: ARM64 + Processor Arch: BP_ARM64 Platform ID: Linux CSD Version: '15E216' CPU: diff --git a/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp b/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp index 47cfd5bd273..99717e7fe34 100644 --- a/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp +++ b/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp @@ -173,7 +173,7 @@ ArchSpec MinidumpParser::GetArchitecture() { case ProcessorArchitecture::ARM: triple.setArch(llvm::Triple::ArchType::arm); break; - case ProcessorArchitecture::ARM64: + case ProcessorArchitecture::BP_ARM64: triple.setArch(llvm::Triple::ArchType::aarch64); break; default: diff --git a/lldb/test/Shell/Minidump/dump-all.test b/lldb/test/Shell/Minidump/dump-all.test index 92f2be24e17..507c1688bb8 100644 --- a/lldb/test/Shell/Minidump/dump-all.test +++ b/lldb/test/Shell/Minidump/dump-all.test @@ -57,7 +57,7 @@ --- !minidump Streams: - Type: SystemInfo - Processor Arch: ARM64 + Processor Arch: BP_ARM64 Platform ID: Linux CSD Version: '15E216' CPU: diff --git a/lldb/test/Shell/Minidump/fb-dump.test b/lldb/test/Shell/Minidump/fb-dump.test index 1cd777c6d71..319db2f3d36 100644 --- a/lldb/test/Shell/Minidump/fb-dump.test +++ b/lldb/test/Shell/Minidump/fb-dump.test @@ -61,7 +61,7 @@ --- !minidump Streams: - Type: SystemInfo - Processor Arch: ARM64 + Processor Arch: BP_ARM64 Platform ID: Linux CSD Version: '15E216' CPU: |
