diff options
| author | Konrad Kleine <kkleine@redhat.com> | 2019-10-08 15:56:02 +0000 |
|---|---|---|
| committer | Konrad Kleine <kkleine@redhat.com> | 2019-10-08 15:56:02 +0000 |
| commit | 6d7fb29914e3dd9e7f7d7524c5f98367a1aa613a (patch) | |
| tree | e3d992bbeffd56a9b0ccc743e91063fc5a2d7a10 /lldb | |
| parent | d80c2520d9f8cb660bbd10b8ff7b78d7f03ad339 (diff) | |
| download | bcm5719-llvm-6d7fb29914e3dd9e7f7d7524c5f98367a1aa613a.tar.gz bcm5719-llvm-6d7fb29914e3dd9e7f7d7524c5f98367a1aa613a.zip | |
[lldb] Avoid resource leak
Summary:
Before the pointer variable `args_dict` was assigned the result of an
allocation with `new` and then `args_dict` is passed to
`GetValueForKeyAsDictionary` which immediatly and unconditionally
assigns `args_dict` to `nullptr`:
```
bool GetValueForKeyAsDictionary(llvm::StringRef key,
Dictionary *&result) const {
result = nullptr;
```
This caused a memory leak which was found in my coverity scan instance
under CID 224753: https://scan.coverity.com/projects/kwk-llvm-project.
Reviewers: jankratochvil, teemperor
Reviewed By: teemperor
Subscribers: teemperor, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D68638
llvm-svn: 374071
Diffstat (limited to 'lldb')
| -rw-r--r-- | lldb/source/Breakpoint/BreakpointResolverScripted.cpp | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/source/Breakpoint/BreakpointResolverScripted.cpp b/lldb/source/Breakpoint/BreakpointResolverScripted.cpp index 8363795a4d7..c6833ae101a 100644 --- a/lldb/source/Breakpoint/BreakpointResolverScripted.cpp +++ b/lldb/source/Breakpoint/BreakpointResolverScripted.cpp @@ -92,7 +92,7 @@ BreakpointResolverScripted::CreateFromStructuredData( depth = (lldb::SearchDepth) depth_as_int; StructuredDataImpl *args_data_impl = new StructuredDataImpl(); - StructuredData::Dictionary *args_dict = new StructuredData::Dictionary(); + StructuredData::Dictionary *args_dict = nullptr; success = options_dict.GetValueForKeyAsDictionary( GetKey(OptionNames::ScriptArgs), args_dict); if (success) { |
