diff options
| author | Enrico Granata <egranata@apple.com> | 2016-03-24 21:32:39 +0000 |
|---|---|---|
| committer | Enrico Granata <egranata@apple.com> | 2016-03-24 21:32:39 +0000 |
| commit | 3cf9ff12c51e1a446f019c001472f30024583fda (patch) | |
| tree | 0fc4d36d39633640a2d5fdc8b951d912f0bbb365 /lldb | |
| parent | 8160812e26e71c563b63d17768ab177856bf4dba (diff) | |
| download | bcm5719-llvm-3cf9ff12c51e1a446f019c001472f30024583fda.tar.gz bcm5719-llvm-3cf9ff12c51e1a446f019c001472f30024583fda.zip | |
Make 'type lookup' print an error message instead of complete radio silence when it can't find a type matching user input
It would be fun to make it provide suggestions (e.g. 'can't find NString, did you mean NSString instead?'), but this worries me a little bit on the account of just how thorough of a type system scan it would have to do
llvm-svn: 264343
Diffstat (limited to 'lldb')
| -rw-r--r-- | lldb/packages/Python/lldbsuite/test/functionalities/type_lookup/TestTypeLookup.py | 1 | ||||
| -rw-r--r-- | lldb/source/Commands/CommandObjectType.cpp | 3 |
2 files changed, 4 insertions, 0 deletions
diff --git a/lldb/packages/Python/lldbsuite/test/functionalities/type_lookup/TestTypeLookup.py b/lldb/packages/Python/lldbsuite/test/functionalities/type_lookup/TestTypeLookup.py index 1261983c887..774eb437b78 100644 --- a/lldb/packages/Python/lldbsuite/test/functionalities/type_lookup/TestTypeLookup.py +++ b/lldb/packages/Python/lldbsuite/test/functionalities/type_lookup/TestTypeLookup.py @@ -42,3 +42,4 @@ class TypeLookupTestCase(TestBase): self.expect('type lookup NSURL', substrs=['NSURL']) self.expect('type lookup NSArray', substrs=['NSArray']) self.expect('type lookup NSObject', substrs=['NSObject', 'isa']) + self.expect('type lookup PleaseDontBeARealTypeThatExists', substrs=["no type was found matching 'PleaseDontBeARealTypeThatExists'"]) diff --git a/lldb/source/Commands/CommandObjectType.cpp b/lldb/source/Commands/CommandObjectType.cpp index f291f115e45..23e3c0e9075 100644 --- a/lldb/source/Commands/CommandObjectType.cpp +++ b/lldb/source/Commands/CommandObjectType.cpp @@ -3404,6 +3404,9 @@ public: } } + if (!any_found) + result.AppendMessageWithFormat("no type was found matching '%s'\n", name_of_type); + result.SetStatus (any_found ? lldb::eReturnStatusSuccessFinishResult : lldb::eReturnStatusSuccessFinishNoResult); return true; } |

