summaryrefslogtreecommitdiffstats
path: root/lldb
diff options
context:
space:
mode:
authorRaphael Isemann <teemperor@gmail.com>2019-08-08 16:41:32 +0000
committerRaphael Isemann <teemperor@gmail.com>2019-08-08 16:41:32 +0000
commit0e5eef5c8f47e4715e8ef694fb1e28c0a825a57f (patch)
tree7ff75ed493ed78ed668db1f2798c930d12c08fb1 /lldb
parenteb7a553db86f5e1b0b8e67c77f94cab81bb54fe8 (diff)
downloadbcm5719-llvm-0e5eef5c8f47e4715e8ef694fb1e28c0a825a57f.tar.gz
bcm5719-llvm-0e5eef5c8f47e4715e8ef694fb1e28c0a825a57f.zip
[lldb][NFC] Simplify return in MaybeHandleVariable
This function anyway returns true, no need to do this extra work. llvm-svn: 368309
Diffstat (limited to 'lldb')
-rw-r--r--lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp13
1 files changed, 4 insertions, 9 deletions
diff --git a/lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp b/lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
index ae91e18e8da..e0d40879185 100644
--- a/lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
+++ b/lldb/source/Plugins/ExpressionParser/Clang/IRForTarget.cpp
@@ -1387,15 +1387,10 @@ bool IRForTarget::MaybeHandleVariable(Value *llvm_value_ptr) {
PrintType(value_type).c_str(), *value_size, value_alignment);
}
- if (named_decl &&
- !m_decl_map->AddValueToStruct(
- named_decl, lldb_private::ConstString(name.c_str()), llvm_value_ptr,
- *value_size, value_alignment)) {
- if (!global_variable->hasExternalLinkage())
- return true;
- else
- return true;
- }
+ if (named_decl)
+ m_decl_map->AddValueToStruct(
+ named_decl, lldb_private::ConstString(name.c_str()), llvm_value_ptr,
+ *value_size, value_alignment);
} else if (dyn_cast<llvm::Function>(llvm_value_ptr)) {
if (log)
LLDB_LOGF(log, "Function pointers aren't handled right now");
OpenPOWER on IntegriCloud