diff options
author | Zachary Turner <zturner@google.com> | 2016-08-30 18:12:11 +0000 |
---|---|---|
committer | Zachary Turner <zturner@google.com> | 2016-08-30 18:12:11 +0000 |
commit | d08f09c1130acc528cf5f417bcf9f9de4dd4b27d (patch) | |
tree | cbf9510969c7484ad4296d217397b361ca1d63f4 /lldb/unittests/Utility/StringExtractorTest.cpp | |
parent | b7668d516443231cba62e29786463587b61f90bb (diff) | |
download | bcm5719-llvm-d08f09c1130acc528cf5f417bcf9f9de4dd4b27d.tar.gz bcm5719-llvm-d08f09c1130acc528cf5f417bcf9f9de4dd4b27d.zip |
Convert some StringExtractor functions to accept MutableArrayRefs.
MutableArrayRef<T> is essentially a safer version of passing around
(T*, length) pairs and provides some convenient functions for working
with the data without having to manually manipulate indices.
This is a minor NFC.
llvm-svn: 280123
Diffstat (limited to 'lldb/unittests/Utility/StringExtractorTest.cpp')
-rw-r--r-- | lldb/unittests/Utility/StringExtractorTest.cpp | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/lldb/unittests/Utility/StringExtractorTest.cpp b/lldb/unittests/Utility/StringExtractorTest.cpp index 5bcf10eb59a..79e6e78d75b 100644 --- a/lldb/unittests/Utility/StringExtractorTest.cpp +++ b/lldb/unittests/Utility/StringExtractorTest.cpp @@ -243,7 +243,7 @@ TEST_F (StringExtractorTest, GetHexBytes) StringExtractor ex(kHexEncodedBytes); uint8_t dst[kValidHexPairs]; - ASSERT_EQ(kValidHexPairs, ex.GetHexBytes (dst, kValidHexPairs, 0xde)); + ASSERT_EQ(kValidHexPairs, ex.GetHexBytes (dst, 0xde)); EXPECT_EQ(0xab,dst[0]); EXPECT_EQ(0xcd,dst[1]); EXPECT_EQ(0xef,dst[2]); @@ -267,7 +267,7 @@ TEST_F (StringExtractorTest, GetHexBytes_Underflow) StringExtractor ex(kHexEncodedBytes); uint8_t dst[12]; - ASSERT_EQ(kValidHexPairs, ex.GetHexBytes (dst, sizeof(dst), 0xde)); + ASSERT_EQ(kValidHexPairs, ex.GetHexBytes (dst, 0xde)); EXPECT_EQ(0xab,dst[0]); EXPECT_EQ(0xcd,dst[1]); EXPECT_EQ(0xef,dst[2]); @@ -297,7 +297,7 @@ TEST_F (StringExtractorTest, GetHexBytes_Partial) uint8_t dst[12]; memset(dst, 0xab, sizeof(dst)); - ASSERT_EQ(kReadBytes, ex.GetHexBytes (dst, kReadBytes, 0xde)); + ASSERT_EQ(kReadBytes, ex.GetHexBytes (llvm::MutableArrayRef<uint8_t>(dst, kReadBytes), 0xde)); EXPECT_EQ(0xab,dst[0]); EXPECT_EQ(0xcd,dst[1]); EXPECT_EQ(0xef,dst[2]); @@ -326,7 +326,7 @@ TEST_F (StringExtractorTest, GetHexBytesAvail) StringExtractor ex(kHexEncodedBytes); uint8_t dst[kValidHexPairs]; - ASSERT_EQ(kValidHexPairs, ex.GetHexBytesAvail (dst, kValidHexPairs)); + ASSERT_EQ(kValidHexPairs, ex.GetHexBytesAvail (dst)); EXPECT_EQ(0xab,dst[0]); EXPECT_EQ(0xcd,dst[1]); EXPECT_EQ(0xef,dst[2]); @@ -351,7 +351,7 @@ TEST_F (StringExtractorTest, GetHexBytesAvail_Underflow) uint8_t dst[12]; memset(dst, 0xef, sizeof(dst)); - ASSERT_EQ(kValidHexPairs, ex.GetHexBytesAvail (dst, sizeof(dst))); + ASSERT_EQ(kValidHexPairs, ex.GetHexBytesAvail (dst)); EXPECT_EQ(0xab,dst[0]); EXPECT_EQ(0xcd,dst[1]); EXPECT_EQ(0xef,dst[2]); @@ -381,7 +381,7 @@ TEST_F (StringExtractorTest, GetHexBytesAvail_Partial) uint8_t dst[12]; memset(dst, 0xab, sizeof(dst)); - ASSERT_EQ(kReadBytes, ex.GetHexBytesAvail (dst, kReadBytes)); + ASSERT_EQ(kReadBytes, ex.GetHexBytesAvail (llvm::MutableArrayRef<uint8_t>(dst, kReadBytes))); EXPECT_EQ(0xab,dst[0]); EXPECT_EQ(0xcd,dst[1]); EXPECT_EQ(0xef,dst[2]); |