summaryrefslogtreecommitdiffstats
path: root/lldb/unittests/Process/gdb-remote
diff options
context:
space:
mode:
authorPavel Labath <labath@google.com>2017-06-06 14:06:22 +0000
committerPavel Labath <labath@google.com>2017-06-06 14:06:22 +0000
commit32f29fac41f0bfa331bbb77c3dbc6d22a9647387 (patch)
tree4981ce996791213aa45917f05c2372bfe98566b5 /lldb/unittests/Process/gdb-remote
parent10c41f37b5ae69ddaec7a81f5141cf00090bae22 (diff)
downloadbcm5719-llvm-32f29fac41f0bfa331bbb77c3dbc6d22a9647387.tar.gz
bcm5719-llvm-32f29fac41f0bfa331bbb77c3dbc6d22a9647387.zip
Fix assorted compiler warnings. NFC
llvm-svn: 304796
Diffstat (limited to 'lldb/unittests/Process/gdb-remote')
-rw-r--r--lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp19
1 files changed, 9 insertions, 10 deletions
diff --git a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
index 6fbeab13b82..8f6f9f0684a 100644
--- a/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
+++ b/lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationClientTest.cpp
@@ -404,7 +404,7 @@ TEST_F(GDBRemoteCommunicationClientTest, SendStartTracePacket) {
R"( {"psb" : 1,"tracetech" : "intel-pt"},"threadid" : 35,"type" : 1})";
HandlePacket(server, (expected_packet1 + expected_packet2), "1");
ASSERT_TRUE(error.Success());
- ASSERT_EQ(result.get(), 1);
+ ASSERT_EQ(result.get(), 1u);
error.Clear();
result = std::async(std::launch::async, [&] {
@@ -466,7 +466,7 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetDataPacket) {
std::string expected_packet2 = R"("traceid" : 3})";
HandlePacket(server, expected_packet1+expected_packet2, "123456");
ASSERT_TRUE(result.get().Success());
- ASSERT_EQ(buffer.size(), 3);
+ ASSERT_EQ(buffer.size(), 3u);
ASSERT_EQ(buf[0], 0x12);
ASSERT_EQ(buf[1], 0x34);
ASSERT_EQ(buf[2], 0x56);
@@ -478,7 +478,7 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetDataPacket) {
HandlePacket(server, expected_packet1+expected_packet2, "E23");
ASSERT_FALSE(result.get().Success());
- ASSERT_EQ(buffer2.size(), 0);
+ ASSERT_EQ(buffer2.size(), 0u);
}
TEST_F(GDBRemoteCommunicationClientTest, SendGetMetaDataPacket) {
@@ -504,7 +504,7 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetMetaDataPacket) {
std::string expected_packet2 = R"("traceid" : 3})";
HandlePacket(server, expected_packet1+expected_packet2, "123456");
ASSERT_TRUE(result.get().Success());
- ASSERT_EQ(buffer.size(), 3);
+ ASSERT_EQ(buffer.size(), 3u);
ASSERT_EQ(buf[0], 0x12);
ASSERT_EQ(buf[1], 0x34);
ASSERT_EQ(buf[2], 0x56);
@@ -516,7 +516,7 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetMetaDataPacket) {
HandlePacket(server, expected_packet1+expected_packet2, "E23");
ASSERT_FALSE(result.get().Success());
- ASSERT_EQ(buffer2.size(), 0);
+ ASSERT_EQ(buffer2.size(), 0u);
}
TEST_F(GDBRemoteCommunicationClientTest, SendGetTraceConfigPacket) {
@@ -543,8 +543,8 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetTraceConfigPacket) {
R"(],"metabuffersize" : 8192,"threadid" : 35,"type" : 1}])";
HandlePacket(server, expected_packet, response1+response2);
ASSERT_TRUE(result.get().Success());
- ASSERT_EQ(options.getTraceBufferSize(), 8192);
- ASSERT_EQ(options.getMetaDataBufferSize(), 8192);
+ ASSERT_EQ(options.getTraceBufferSize(), 8192u);
+ ASSERT_EQ(options.getMetaDataBufferSize(), 8192u);
ASSERT_EQ(options.getType(), 1);
auto custom_params = options.getTraceParams();
@@ -554,9 +554,8 @@ TEST_F(GDBRemoteCommunicationClientTest, SendGetTraceConfigPacket) {
ASSERT_TRUE(custom_params);
ASSERT_EQ(custom_params->GetType(), eStructuredDataTypeDictionary);
- ASSERT_TRUE(
- custom_params->GetValueForKeyAsInteger<uint64_t>("psb", psb_value));
- ASSERT_EQ(psb_value, 1);
+ ASSERT_TRUE(custom_params->GetValueForKeyAsInteger("psb", psb_value));
+ ASSERT_EQ(psb_value, 1u);
ASSERT_TRUE(
custom_params->GetValueForKeyAsString("tracetech", trace_tech_value));
ASSERT_STREQ(trace_tech_value.data(), "intel-pt");
OpenPOWER on IntegriCloud