diff options
author | Jorge Gorbe Moya <jgorbe@google.com> | 2019-03-13 23:50:35 +0000 |
---|---|---|
committer | Jorge Gorbe Moya <jgorbe@google.com> | 2019-03-13 23:50:35 +0000 |
commit | d383a342aaa001439d59cb09d3a86ca3c54f8713 (patch) | |
tree | bf6d2588c71e4d1a9c2d28e2726f8be2db685c3e /lldb/tools/lldb-vscode | |
parent | e4aa3f82640a298705fcb4160432c76fff2db437 (diff) | |
download | bcm5719-llvm-d383a342aaa001439d59cb09d3a86ca3c54f8713.tar.gz bcm5719-llvm-d383a342aaa001439d59cb09d3a86ca3c54f8713.zip |
[lldb-vscode] Don't try to launch an invalid program.
If an invalid program is specified, lldb-vscode will send back a
response with "success" = false, but then will continue executing the
rest of request_launch(), try to launch the program anyway and try to
send another response (possibly using the `response` object after it was
moved).
This change adds a return statement so we stop executing the handler
after producing the first failing response.
Differential Revision: https://reviews.llvm.org/D59340
llvm-svn: 356110
Diffstat (limited to 'lldb/tools/lldb-vscode')
-rw-r--r-- | lldb/tools/lldb-vscode/lldb-vscode.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lldb/tools/lldb-vscode/lldb-vscode.cpp b/lldb/tools/lldb-vscode/lldb-vscode.cpp index 3aed079e3f4..1fbcd2ee089 100644 --- a/lldb/tools/lldb-vscode/lldb-vscode.cpp +++ b/lldb/tools/lldb-vscode/lldb-vscode.cpp @@ -1245,6 +1245,7 @@ void request_launch(const llvm::json::Object &request) { response, "message", llvm::formatv("Could not load program '{0}'.", program).str()); g_vsc.SendJSON(llvm::json::Value(std::move(response))); + return; } } |