[NFC] Remove ASCII lines from comments

A lot of comments in LLDB are surrounded by an ASCII line to delimit the
begging and end of the comment.

Its use is not really consistent across the code base, sometimes the
lines are longer, sometimes they are shorter and sometimes they are
omitted. Furthermore, it looks kind of weird with the 80 column limit,
where the comment actually extends past the line, but not by much.
Furthermore, when /// is used for Doxygen comments, it looks
particularly odd. And when // is used, it incorrectly gives the
impression that it's actually a Doxygen comment.

I assume these lines were added to improve distinguishing between
comments and code. However, given that todays editors and IDEs do a
great job at highlighting comments, I think it's worth to drop this for
the sake of consistency. The alternative is fixing all the
inconsistencies, which would create a lot more churn.

Differential revision: https://reviews.llvm.org/D60508

llvm-svn: 358135

1 files changed, 0 insertions, 54 deletions

diff --git a/lldb/tools/lldb-vscode/lldb-vscode.cpp b/lldb/tools/lldb-vscode/lldb-vscode.cpp
index 2cad12f8d5c..d5b512389ad 100644
--- a/lldb/tools/lldb-vscode/lldb-vscode.cpp
+++ b/lldb/tools/lldb-vscode/lldb-vscode.cpp
@@ -119,9 +119,7 @@ std::vector<const char *> MakeArgv(const llvm::ArrayRef<std::string> &strs) {
   return argv;
 }
 
-//----------------------------------------------------------------------
 // Send a "exited" event to indicate the process has exited.
-//----------------------------------------------------------------------
 void SendProcessExitedEvent(lldb::SBProcess &process) {
   llvm::json::Object event(CreateEventObject("exited"));
   llvm::json::Object body;
@@ -139,10 +137,8 @@ void SendThreadExitedEvent(lldb::tid_t tid) {
   g_vsc.SendJSON(llvm::json::Value(std::move(event)));
 }
 
-//----------------------------------------------------------------------
 // Send a "terminated" event to indicate the process is done being
 // debugged.
-//----------------------------------------------------------------------
 void SendTerminatedEvent() {
   if (!g_vsc.sent_terminated_event) {
     g_vsc.sent_terminated_event = true;
@@ -152,10 +148,8 @@ void SendTerminatedEvent() {
   }
 }
 
-//----------------------------------------------------------------------
 // Send a thread stopped event for all threads as long as the process
 // is stopped.
-//----------------------------------------------------------------------
 void SendThreadStoppedEvent() {
   lldb::SBProcess process = g_vsc.target.GetProcess();
   if (process.IsValid()) {
@@ -228,7 +222,6 @@ void SendThreadStoppedEvent() {
   g_vsc.RunStopCommands();
 }
 
-//----------------------------------------------------------------------
 // "ProcessEvent": {
 //   "allOf": [
 //     { "$ref": "#/definitions/Event" },
@@ -283,7 +276,6 @@ void SendThreadStoppedEvent() {
 //     }
 //   ]
 // }
-//----------------------------------------------------------------------
 void SendProcessEvent(LaunchMethod launch_method) {
   lldb::SBFileSpec exe_fspec = g_vsc.target.GetExecutable();
   char exe_path[PATH_MAX];
@@ -311,10 +303,8 @@ void SendProcessEvent(LaunchMethod launch_method) {
   g_vsc.SendJSON(llvm::json::Value(std::move(event)));
 }
 
-//----------------------------------------------------------------------
 // Grab any STDOUT and STDERR from the process and send it up to VS Code
 // via an "output" event to the "stdout" and "stderr" categories.
-//----------------------------------------------------------------------
 void SendStdOutStdErr(lldb::SBProcess &process) {
   char buffer[1024];
   size_t count;
@@ -324,13 +314,11 @@ void SendStdOutStdErr(lldb::SBProcess &process) {
     g_vsc.SendOutput(OutputType::Stderr, llvm::StringRef(buffer, count));
 }
 
-//----------------------------------------------------------------------
 // All events from the debugger, target, process, thread and frames are
 // received in this function that runs in its own thread. We are using a
 // "FILE *" to output packets back to VS Code and they have mutexes in them
 // them prevent multiple threads from writing simultaneously so no locking
 // is required.
-//----------------------------------------------------------------------
 void EventThreadFunction() {
   lldb::SBEvent event;
   lldb::SBListener listener = g_vsc.debugger.GetListener();
@@ -420,10 +408,8 @@ void EventThreadFunction() {
   }
 }
 
-//----------------------------------------------------------------------
 // Both attach and launch take a either a sourcePath or sourceMap
 // argument (or neither), from which we need to set the target.source-map.
-//----------------------------------------------------------------------
 void SetSourceMapFromArguments(const llvm::json::Object &arguments) {
   const char *sourceMapHelp =
       "source must be be an array of two-element arrays, "
@@ -465,7 +451,6 @@ void SetSourceMapFromArguments(const llvm::json::Object &arguments) {
   }
 }
 
-//----------------------------------------------------------------------
 // "AttachRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -494,7 +479,6 @@ void SetSourceMapFromArguments(const llvm::json::Object &arguments) {
 //     acknowledgement, so no body field is required."
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_attach(const llvm::json::Object &request) {
   llvm::json::Object response;
   lldb::SBError error;
@@ -602,7 +586,6 @@ void request_attach(const llvm::json::Object &request) {
   }
 }
 
-//----------------------------------------------------------------------
 // "ContinueRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -657,7 +640,6 @@ void request_attach(const llvm::json::Object &request) {
 //     "required": [ "body" ]
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_continue(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -673,7 +655,6 @@ void request_continue(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "ConfigurationDoneRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //             "type": "object",
@@ -705,7 +686,6 @@ void request_continue(const llvm::json::Object &request) {
 //             just an acknowledgement, so no body field is required."
 //             }]
 // },
-//----------------------------------------------------------------------
 void request_configurationDone(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -716,7 +696,6 @@ void request_configurationDone(const llvm::json::Object &request) {
     g_vsc.target.GetProcess().Continue();
 }
 
-//----------------------------------------------------------------------
 // "DisconnectRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -761,7 +740,6 @@ void request_configurationDone(const llvm::json::Object &request) {
 //                     acknowledgement, so no body field is required."
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_disconnect(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -840,7 +818,6 @@ void request_exceptionInfo(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 //  "EvaluateRequest": {
 //    "allOf": [ { "$ref": "#/definitions/Request" }, {
 //      "type": "object",
@@ -942,7 +919,6 @@ void request_exceptionInfo(const llvm::json::Object &request) {
 //      "required": [ "body" ]
 //    }]
 //  }
-//----------------------------------------------------------------------
 void request_evaluate(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -992,7 +968,6 @@ void request_evaluate(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "InitializeRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -1069,7 +1044,6 @@ void request_evaluate(const llvm::json::Object &request) {
 //     }
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_initialize(const llvm::json::Object &request) {
   g_vsc.debugger = lldb::SBDebugger::Create(true /*source_init_files*/);
   // Create an empty target right away since we might get breakpoint requests
@@ -1163,7 +1137,6 @@ void request_initialize(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "LaunchRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -1198,7 +1171,6 @@ void request_initialize(const llvm::json::Object &request) {
 //                     acknowledgement, so no body field is required."
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_launch(const llvm::json::Object &request) {
   llvm::json::Object response;
   lldb::SBError error;
@@ -1297,7 +1269,6 @@ void request_launch(const llvm::json::Object &request) {
   g_vsc.debugger.SetAsync(true);
 }
 
-//----------------------------------------------------------------------
 // "NextRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -1336,7 +1307,6 @@ void request_launch(const llvm::json::Object &request) {
 //                     acknowledgement, so no body field is required."
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_next(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -1353,7 +1323,6 @@ void request_next(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "PauseRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -1390,7 +1359,6 @@ void request_next(const llvm::json::Object &request) {
 //     acknowledgement, so no body field is required."
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_pause(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -1399,7 +1367,6 @@ void request_pause(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "ScopesRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -1451,7 +1418,6 @@ void request_pause(const llvm::json::Object &request) {
 //     "required": [ "body" ]
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_scopes(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -1477,7 +1443,6 @@ void request_scopes(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "SetBreakpointsRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -1588,7 +1553,6 @@ void request_scopes(const llvm::json::Object &request) {
 //   },
 //   "required": [ "line" ]
 // }
-//----------------------------------------------------------------------
 void request_setBreakpoints(const llvm::json::Object &request) {
   llvm::json::Object response;
   lldb::SBError error;
@@ -1670,7 +1634,6 @@ void request_setBreakpoints(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "SetExceptionBreakpointsRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -1718,7 +1681,6 @@ void request_setBreakpoints(const llvm::json::Object &request) {
 //     just an acknowledgement, so no body field is required."
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_setExceptionBreakpoints(const llvm::json::Object &request) {
   llvm::json::Object response;
   lldb::SBError error;
@@ -1747,7 +1709,6 @@ void request_setExceptionBreakpoints(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "SetFunctionBreakpointsRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -1826,7 +1787,6 @@ void request_setExceptionBreakpoints(const llvm::json::Object &request) {
 //     "required": [ "body" ]
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_setFunctionBreakpoints(const llvm::json::Object &request) {
   llvm::json::Object response;
   lldb::SBError error;
@@ -1883,7 +1843,6 @@ void request_setFunctionBreakpoints(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "SourceRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -1942,7 +1901,6 @@ void request_setFunctionBreakpoints(const llvm::json::Object &request) {
 //     "required": [ "body" ]
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_source(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -1961,7 +1919,6 @@ void request_source(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "StackTraceRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -2032,7 +1989,6 @@ void request_source(const llvm::json::Object &request) {
 //     "required": [ "body" ]
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_stackTrace(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -2058,7 +2014,6 @@ void request_stackTrace(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "StepInRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -2104,7 +2059,6 @@ void request_stackTrace(const llvm::json::Object &request) {
 //     acknowledgement, so no body field is required."
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_stepIn(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -2121,7 +2075,6 @@ void request_stepIn(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "StepOutRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -2158,7 +2111,6 @@ void request_stepIn(const llvm::json::Object &request) {
 //     acknowledgement, so no body field is required."
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_stepOut(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -2175,7 +2127,6 @@ void request_stepOut(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "ThreadsRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -2211,7 +2162,6 @@ void request_stepOut(const llvm::json::Object &request) {
 //     "required": [ "body" ]
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_threads(const llvm::json::Object &request) {
 
   lldb::SBProcess process = g_vsc.target.GetProcess();
@@ -2233,7 +2183,6 @@ void request_threads(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "SetVariableRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -2316,7 +2265,6 @@ void request_threads(const llvm::json::Object &request) {
 //     "required": [ "body" ]
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_setVariable(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);
@@ -2426,7 +2374,6 @@ void request_setVariable(const llvm::json::Object &request) {
   g_vsc.SendJSON(llvm::json::Value(std::move(response)));
 }
 
-//----------------------------------------------------------------------
 // "VariablesRequest": {
 //   "allOf": [ { "$ref": "#/definitions/Request" }, {
 //     "type": "object",
@@ -2500,7 +2447,6 @@ void request_setVariable(const llvm::json::Object &request) {
 //     "required": [ "body" ]
 //   }]
 // }
-//----------------------------------------------------------------------
 void request_variables(const llvm::json::Object &request) {
   llvm::json::Object response;
   FillResponse(request, response);