Replace sprintf with snprintf to avoid a crash.

During testing -data-list-register-values, I saw a crash here due to buffer overflow.
This commit should fix the crash. There is still problem with printing 1-byte register
in some cases that I will fix separately.

No regression on MI test cases.

llvm-svn: 235991

1 files changed, 4 insertions, 2 deletions

diff --git a/lldb/tools/lldb-mi/MIUtilString.cpp b/lldb/tools/lldb-mi/MIUtilString.cpp
index 9fd1aef4e98..675bc465639 100644
--- a/lldb/tools/lldb-mi/MIUtilString.cpp
+++ b/lldb/tools/lldb-mi/MIUtilString.cpp
@@ -17,6 +17,7 @@
 
 // In-house headers:
 #include "MIUtilString.h"
+#include "Platform.h"
 
 //++ ------------------------------------------------------------------------------------
 // Details: CMIUtilString constructor.
@@ -844,8 +845,9 @@ CMIUtilString::Escape(const bool vbEscapeQuotes /* = false */) const
                     strNew.push_back(cUnescapedChar);
                 else
                 {
-                    char strEscapedChar[sizeof("\\xXX")];
-                    ::sprintf(strEscapedChar, "\\x%02" PRIx8, cUnescapedChar);
+                    const size_t size = sizeof("\\xXX");
+                    char strEscapedChar[size];
+                    ::snprintf(strEscapedChar, size, "\\x%02" PRIx8, cUnescapedChar);
                     strNew.append(strEscapedChar);
                 }
                 break;