diff options
author | Jonas Devlieghere <jonas@devlieghere.com> | 2019-04-10 20:48:55 +0000 |
---|---|---|
committer | Jonas Devlieghere <jonas@devlieghere.com> | 2019-04-10 20:48:55 +0000 |
commit | 8b3af63b8993e45b1783853a3fcf6f36bfbed81b (patch) | |
tree | 41759d08361beda32b90e345d8033aecd2e15088 /lldb/tools/lldb-mi/MICmnMIValueList.cpp | |
parent | 66b6bb1766b3e5eea56b26fc91d03f1fccbe15e4 (diff) | |
download | bcm5719-llvm-8b3af63b8993e45b1783853a3fcf6f36bfbed81b.tar.gz bcm5719-llvm-8b3af63b8993e45b1783853a3fcf6f36bfbed81b.zip |
[NFC] Remove ASCII lines from comments
A lot of comments in LLDB are surrounded by an ASCII line to delimit the
begging and end of the comment.
Its use is not really consistent across the code base, sometimes the
lines are longer, sometimes they are shorter and sometimes they are
omitted. Furthermore, it looks kind of weird with the 80 column limit,
where the comment actually extends past the line, but not by much.
Furthermore, when /// is used for Doxygen comments, it looks
particularly odd. And when // is used, it incorrectly gives the
impression that it's actually a Doxygen comment.
I assume these lines were added to improve distinguishing between
comments and code. However, given that todays editors and IDEs do a
great job at highlighting comments, I think it's worth to drop this for
the sake of consistency. The alternative is fixing all the
inconsistencies, which would create a lot more churn.
Differential revision: https://reviews.llvm.org/D60508
llvm-svn: 358135
Diffstat (limited to 'lldb/tools/lldb-mi/MICmnMIValueList.cpp')
-rw-r--r-- | lldb/tools/lldb-mi/MICmnMIValueList.cpp | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/lldb/tools/lldb-mi/MICmnMIValueList.cpp b/lldb/tools/lldb-mi/MICmnMIValueList.cpp index 3bda4a47474..038d3ae36f0 100644 --- a/lldb/tools/lldb-mi/MICmnMIValueList.cpp +++ b/lldb/tools/lldb-mi/MICmnMIValueList.cpp @@ -11,7 +11,6 @@ #include "MICmnResources.h" //++ -//------------------------------------------------------------------------------------ // Details: CMICmnMIValueList constructor. // Type: Method. // Args: vbValueTypeList - (R) True = yes value type list, false = result @@ -24,7 +23,6 @@ CMICmnMIValueList::CMICmnMIValueList(const bool vbValueTypeList) { } //++ -//------------------------------------------------------------------------------------ // Details: CMICmnMIValueList constructor. // Construct a results only list. // return MIstatus::failure. @@ -40,7 +38,6 @@ CMICmnMIValueList::CMICmnMIValueList(const CMICmnMIValueResult &vResult) { } //++ -//------------------------------------------------------------------------------------ // Details: CMICmnMIValueList constructor. // Construct a value only list. // Type: Method. @@ -55,7 +52,6 @@ CMICmnMIValueList::CMICmnMIValueList(const CMICmnMIValue &vValue) { } //++ -//------------------------------------------------------------------------------------ // Details: CMICmnMIValueList destructor. // Type: Overrideable. // Args: None. @@ -65,7 +61,6 @@ CMICmnMIValueList::CMICmnMIValueList(const CMICmnMIValue &vValue) { CMICmnMIValueList::~CMICmnMIValueList() {} //++ -//------------------------------------------------------------------------------------ // Details: Build the result value's mandatory data part, one tuple // Type: Method. // Args: None. @@ -78,7 +73,6 @@ void CMICmnMIValueList::BuildList() { } //++ -//------------------------------------------------------------------------------------ // Details: Add another MI result object to the value list's of list is // results. // Only result objects can be added to a list of result otherwise this @@ -94,7 +88,6 @@ void CMICmnMIValueList::Add(const CMICmnMIValueResult &vResult) { } //++ -//------------------------------------------------------------------------------------ // Details: Add another MI value object to the value list's of list is values. // Only values objects can be added to a list of values otherwise this // function @@ -107,7 +100,6 @@ void CMICmnMIValueList::Add(const CMICmnMIValueResult &vResult) { void CMICmnMIValueList::Add(const CMICmnMIValue &vValue) { BuildList(vValue); } //++ -//------------------------------------------------------------------------------------ // Details: Add another MI result object to the value list's of list is // results. // Only result objects can be added to a list of result otherwise this @@ -134,7 +126,6 @@ void CMICmnMIValueList::BuildList(const CMICmnMIValueResult &vResult) { } //++ -//------------------------------------------------------------------------------------ // Details: Add another MI value object to the value list's of list is values. // Only values objects can be added to a list of values otherwise this // function @@ -164,7 +155,6 @@ void CMICmnMIValueList::BuildList(const CMICmnMIValue &vValue) { } //++ -//------------------------------------------------------------------------------------ // Details: Retrieve the contents of *this value object but without the outer // most // brackets. |