diff options
author | Jonas Devlieghere <jonas@devlieghere.com> | 2019-04-10 20:48:55 +0000 |
---|---|---|
committer | Jonas Devlieghere <jonas@devlieghere.com> | 2019-04-10 20:48:55 +0000 |
commit | 8b3af63b8993e45b1783853a3fcf6f36bfbed81b (patch) | |
tree | 41759d08361beda32b90e345d8033aecd2e15088 /lldb/tools/lldb-mi/MICmdArgValOptionLong.cpp | |
parent | 66b6bb1766b3e5eea56b26fc91d03f1fccbe15e4 (diff) | |
download | bcm5719-llvm-8b3af63b8993e45b1783853a3fcf6f36bfbed81b.tar.gz bcm5719-llvm-8b3af63b8993e45b1783853a3fcf6f36bfbed81b.zip |
[NFC] Remove ASCII lines from comments
A lot of comments in LLDB are surrounded by an ASCII line to delimit the
begging and end of the comment.
Its use is not really consistent across the code base, sometimes the
lines are longer, sometimes they are shorter and sometimes they are
omitted. Furthermore, it looks kind of weird with the 80 column limit,
where the comment actually extends past the line, but not by much.
Furthermore, when /// is used for Doxygen comments, it looks
particularly odd. And when // is used, it incorrectly gives the
impression that it's actually a Doxygen comment.
I assume these lines were added to improve distinguishing between
comments and code. However, given that todays editors and IDEs do a
great job at highlighting comments, I think it's worth to drop this for
the sake of consistency. The alternative is fixing all the
inconsistencies, which would create a lot more churn.
Differential revision: https://reviews.llvm.org/D60508
llvm-svn: 358135
Diffstat (limited to 'lldb/tools/lldb-mi/MICmdArgValOptionLong.cpp')
-rw-r--r-- | lldb/tools/lldb-mi/MICmdArgValOptionLong.cpp | 11 |
1 files changed, 0 insertions, 11 deletions
diff --git a/lldb/tools/lldb-mi/MICmdArgValOptionLong.cpp b/lldb/tools/lldb-mi/MICmdArgValOptionLong.cpp index 2370c314466..3dc9d40f4b5 100644 --- a/lldb/tools/lldb-mi/MICmdArgValOptionLong.cpp +++ b/lldb/tools/lldb-mi/MICmdArgValOptionLong.cpp @@ -11,7 +11,6 @@ #include "MICmdArgContext.h" //++ -//------------------------------------------------------------------------------------ // Details: CMICmdArgValOptionLong constructor. // Type: Method. // Args: None. @@ -22,7 +21,6 @@ CMICmdArgValOptionLong::CMICmdArgValOptionLong() : m_nExpectingNOptions(0), m_eExpectingOptionType(eArgValType_invalid) {} //++ -//------------------------------------------------------------------------------------ // Details: CMICmdArgValOptionLong constructor. // Type: Method. // Args: vrArgName - (R) Argument's name to search by. @@ -40,7 +38,6 @@ CMICmdArgValOptionLong::CMICmdArgValOptionLong(const CMIUtilString &vrArgName, m_nExpectingNOptions(0), m_eExpectingOptionType(eArgValType_invalid) {} //++ -//------------------------------------------------------------------------------------ // Details: CMICmdArgValOptionLong constructor. // Type: Method. // Args: vrArgName - (R) Argument's name to search by. @@ -65,7 +62,6 @@ CMICmdArgValOptionLong::CMICmdArgValOptionLong(const CMIUtilString &vrArgName, m_eExpectingOptionType(veType) {} //++ -//------------------------------------------------------------------------------------ // Details: CMICmdArgValOptionLong destructor. // Type: Overridden. // Args: None. @@ -78,7 +74,6 @@ CMICmdArgValOptionLong::~CMICmdArgValOptionLong() { } //++ -//------------------------------------------------------------------------------------ // Details: Tear down resources used by *this object. // Type: Method. // Args: None. @@ -99,7 +94,6 @@ void CMICmdArgValOptionLong::Destroy() { } //++ -//------------------------------------------------------------------------------------ // Details: Parse the command's argument options string and try to extract the // long // argument *this argument type is looking for. @@ -167,7 +161,6 @@ bool CMICmdArgValOptionLong::Validate(CMICmdArgContext &vwArgContext) { } //++ -//------------------------------------------------------------------------------------ // Details: Parse the text following *this argument and extract the options the // values of // CMICmdArgValListBase::m_eArgType forming argument objects for each @@ -228,7 +221,6 @@ bool CMICmdArgValOptionLong::ExtractExpectedOptions(CMICmdArgContext &vrwTxt, } //++ -//------------------------------------------------------------------------------------ // Details: Examine the string and determine if it is a valid long type option // argument. // Long type argument looks like --someLongOption. @@ -255,7 +247,6 @@ bool CMICmdArgValOptionLong::IsArgLongOption(const CMIUtilString &vrTxt) const { } //++ -//------------------------------------------------------------------------------------ // Details: Examine the string and determine if it is a valid long type option // argument. // Long type argument looks like --someLongOption. @@ -270,7 +261,6 @@ bool CMICmdArgValOptionLong::IsArgOptionCorrect( } //++ -//------------------------------------------------------------------------------------ // Details: Does the argument name of the argument being parsed ATM match the // name of // *this argument object. @@ -285,7 +275,6 @@ bool CMICmdArgValOptionLong::ArgNameMatch(const CMIUtilString &vrTxt) const { } //++ -//------------------------------------------------------------------------------------ // Details: Retrieve the list of CMICmdArgValBase derived option objects found // following // *this long option argument. For example "list-thread-groups [ |