Add logic to MachThreadList::GetThreadID() for the use case of setting a watchpoint

(MachThreadList::EnableHardwareWatchpoint()) where the watchpoint is not associated
with a thread and the current thread, if set, is returned, otherwise we return the
first thread.

Plus minor change to RNBRemote::HandlePacket_z() to use the existing macros to check
the validity of break_id/watch_id.

llvm-svn: 139246

1 files changed, 16 insertions, 4 deletions

diff --git a/lldb/tools/debugserver/source/MacOSX/MachThreadList.cpp b/lldb/tools/debugserver/source/MacOSX/MachThreadList.cpp
index acd38eb7707..33213fbca43 100644
--- a/lldb/tools/debugserver/source/MacOSX/MachThreadList.cpp
+++ b/lldb/tools/debugserver/source/MacOSX/MachThreadList.cpp
@@ -99,14 +99,26 @@ MachThreadList::GetThreadByID (nub_thread_t tid) const
     PTHREAD_MUTEX_LOCKER (locker, m_threads_mutex);
     MachThreadSP thread_sp;
     const size_t num_threads = m_threads.size();
-    for (size_t idx = 0; idx < num_threads; ++idx)
+    if (MachThread::ThreadIDIsValid(tid))
     {
-        if (m_threads[idx]->ThreadID() == tid)
+        for (size_t idx = 0; idx < num_threads; ++idx)
         {
-            thread_sp = m_threads[idx];
-            break;
+            if (m_threads[idx]->ThreadID() == tid)
+            {
+                thread_sp = m_threads[idx];
+                break;
+            }
         }
     }
+    else if (num_threads > 0)
+    {
+        // See DNBWatchpointSet() -> MachProcess::CreateWatchpoint() -> MachProcess::EnableWatchpoint()
+        // -> MachThreadList::EnableHardwareWatchpoint() for a use case of this branch.
+        if (m_current_thread)
+            thread_sp = m_current_thread;
+        else
+            thread_sp = m_threads[0];
+    }
     return thread_sp;
 }