Merge dwarf and dsym tests

Currently most of the test files have a separate dwarf and a separate
dsym test with almost identical content (only the build step is
different). With adding dwo symbol file handling to the test suit it
would increase this to a 3-way duplication. The purpose of this change
is to eliminate this redundancy with generating 2 test case (one dwarf
and one dsym) for each test function specified (dwo handling will be
added at a later commit).

Main design goals:
* There should be no boilerplate code in each test file to support the
  multiple debug info in most of the tests (custom scenarios are
  acceptable in special cases) so adding a new test case is easier and
  we can't miss one of the debug info type.
* In case of a test failure, the debug symbols used during the test run
  have to be cleanly visible from the output of dotest.py to make
  debugging easier both from build bot logs and from local test runs
* Each test case should have a unique, fully qualified name so we can
  run exactly 1 test with "-f <test-case>.<test-function>" syntax
* Test output should be grouped based on test files the same way as it
  happens now (displaying dwarf/dsym results separately isn't
  preferable)

Proposed solution (main logic in lldbtest.py, rest of them are test
cases fixed up for the new style):
* Have only 1 test fuction in the test files what will run for all
  debug info separately and this test function should call just
  "self.build(...)" to build an inferior with the right debug info
* When a class is created by python (the class object, not the class
  instance), we will generate a new test method for each debug info
  format in the test class with the name "<test-function>_<debug-info>"
  and remove the original test method. This way unittest2 see multiple
  test methods (1 for each debug info, pretty much as of now) and will
  handle the test selection and the failure reporting correctly (the
  debug info will be visible from the end of the test name)
* Add new annotation @no_debug_info_test to disable the generation of
  multiple tests for each debug info format when the test don't have an
  inferior

Differential revision: http://reviews.llvm.org/D13028

llvm-svn: 248883

1 files changed, 16 insertions, 32 deletions

diff --git a/lldb/test/lang/objc/objc-dynamic-value/TestObjCDynamicValue.py b/lldb/test/lang/objc/objc-dynamic-value/TestObjCDynamicValue.py
index 61a69cbc993..37a7b078cad 100644
--- a/lldb/test/lang/objc/objc-dynamic-value/TestObjCDynamicValue.py
+++ b/lldb/test/lang/objc/objc-dynamic-value/TestObjCDynamicValue.py
@@ -12,30 +12,6 @@ class ObjCDynamicValueTestCase(TestBase):
 
     mydir = TestBase.compute_mydir(__file__)
 
-    @skipUnlessDarwin
-    @python_api_test
-    @dsym_test
-    @expectedFailureDarwin("llvm.org/pr20271 rdar://18684107")
-    def test_get_dynamic_objc_vals_with_dsym(self):
-        """Test fetching ObjC dynamic values."""
-        if self.getArchitecture() == 'i386':
-            # rdar://problem/9946499
-            self.skipTest("Dynamic types for ObjC V1 runtime not implemented")
-        self.buildDsym()
-        self.do_get_dynamic_vals()
-
-    @skipUnlessDarwin
-    @python_api_test
-    @dwarf_test
-    @expectedFailureDarwin("llvm.org/pr20271 rdar://18684107")
-    def test_get_objc_dynamic_vals_with_dwarf(self):
-        """Test fetching ObjC dynamic values."""
-        if self.getArchitecture() == 'i386':
-            # rdar://problem/9946499
-            self.skipTest("Dynamic types for ObjC V1 runtime not implemented")
-        self.buildDwarf()
-        self.do_get_dynamic_vals()
-
     def setUp(self):
         # Call super's setUp().                                                                                                           
         TestBase.setUp(self)
@@ -49,15 +25,16 @@ class ObjCDynamicValueTestCase(TestBase):
         self.main_before_setProperty_line = line_number(self.source_name,
                                                        '// Break here to see if we can step into real method.')
 
-    def examine_SourceDerived_ptr (self, object):
-        self.assertTrue (object)
-        self.assertTrue (object.GetTypeName().find ('SourceDerived') != -1)
-        derivedValue = object.GetChildMemberWithName ('_derivedValue')
-        self.assertTrue (derivedValue)
-        self.assertTrue (int (derivedValue.GetValue(), 0) == 30)
+    @skipUnlessDarwin
+    @python_api_test
+    @expectedFailureDarwin("llvm.org/pr20271 rdar://18684107")
+    def test_get_objc_dynamic_vals(self):
+        """Test fetching ObjC dynamic values."""
+        if self.getArchitecture() == 'i386':
+            # rdar://problem/9946499
+            self.skipTest("Dynamic types for ObjC V1 runtime not implemented")
 
-    def do_get_dynamic_vals(self):
-        """Make sure we get dynamic values correctly both for compiled in classes and dynamic ones"""
+        self.build()
         exe = os.path.join(os.getcwd(), "a.out")
 
         # Create a target from the debugger.
@@ -188,6 +165,13 @@ class ObjCDynamicValueTestCase(TestBase):
 
         self.examine_SourceDerived_ptr (object_dynamic)
 
+    def examine_SourceDerived_ptr (self, object):
+        self.assertTrue (object)
+        self.assertTrue (object.GetTypeName().find ('SourceDerived') != -1)
+        derivedValue = object.GetChildMemberWithName ('_derivedValue')
+        self.assertTrue (derivedValue)
+        self.assertTrue (int (derivedValue.GetValue(), 0) == 30)
+
 if __name__ == '__main__':
     import atexit
     lldb.SBDebugger.Initialize()