diff options
author | Andrew Kaylor <andrew.kaylor@intel.com> | 2013-05-10 17:19:04 +0000 |
---|---|---|
committer | Andrew Kaylor <andrew.kaylor@intel.com> | 2013-05-10 17:19:04 +0000 |
commit | 29d65744c9290f901cc86a096be942a97a649b61 (patch) | |
tree | 09084e672f8e2950a245702058fe2a414cc1f384 /lldb/test/functionalities/thread/state/TestThreadStates.py | |
parent | 72a196a159b28f26f84d9afec8b2baac11d367bc (diff) | |
download | bcm5719-llvm-29d65744c9290f901cc86a096be942a97a649b61.tar.gz bcm5719-llvm-29d65744c9290f901cc86a096be942a97a649b61.zip |
Adding support for setting thread stop state when a process stops.
This re-submission of this patch fixes a problem where the code sometimes caused a deadlock. The Process::SetPrivateState method was locking the Process::m_private_state variable and then later calling ThreadList::DidStop, which locks the ThreadList mutex. Other methods in ThreadList which were being called from other threads lock the ThreadList mutex and then call Process::GetPrivateState which locks the Process::m_private_state mutex. To avoid deadlocks, Process::SetPrivateState now locks the ThreadList mutex before locking the Process::m_private_state mutex.
llvm-svn: 181609
Diffstat (limited to 'lldb/test/functionalities/thread/state/TestThreadStates.py')
-rw-r--r-- | lldb/test/functionalities/thread/state/TestThreadStates.py | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/lldb/test/functionalities/thread/state/TestThreadStates.py b/lldb/test/functionalities/thread/state/TestThreadStates.py index 7e59b22aaee..185eb50106a 100644 --- a/lldb/test/functionalities/thread/state/TestThreadStates.py +++ b/lldb/test/functionalities/thread/state/TestThreadStates.py @@ -14,14 +14,12 @@ class StopThreadsTestCase(TestBase): @unittest2.skipUnless(sys.platform.startswith("darwin"), "requires Darwin") @dsym_test - @unittest2.expectedFailure("PR-15824") # thread states not properly maintained def test_state_after_breakpoint_with_dsym(self): """Test thread state after breakpoint.""" self.buildDsym() self.thread_state_after_breakpoint_test() @dwarf_test - @unittest2.expectedFailure("PR-15824") # thread states not properly maintained def test_state_after_breakpoint_with_dwarf(self): """Test thread state after breakpoint.""" self.buildDwarf() |