Redesign of the interaction between Python and frozen objects:

 - introduced two new classes ValueObjectConstResultChild and ValueObjectConstResultImpl: the first one is a ValueObjectChild obtained from
   a ValueObjectConstResult, the second is a common implementation backend for VOCR and VOCRCh of method calls meant to read through pointers stored
   in frozen objects ; now such reads transparently move from host to target as required
 - as a consequence of the above, removed code that made target-memory copies of expression results in several places throughout LLDB, and also
   removed code that enabled to recognize an expression result VO as such
 - introduced a new GetPointeeData() method in ValueObject that lets you read a given amount of objects of type T from a VO
   representing a T* or T[], and doing dereferences transparently
   in private layer it returns a DataExtractor ; in public layer it returns an instance of a newly created lldb::SBData
 - as GetPointeeData() does the right thing for both frozen and non-frozen ValueObject's, reimplemented ReadPointedString() to use it
   en lieu of doing the raw read itself
 - introduced a new GetData() method in ValueObject that lets you get a copy of the data that backs the ValueObject (for pointers,
   this returns the address without any previous dereferencing steps ; for arrays it actually reads the whole chunk of memory)
   in public layer this returns an SBData, just like GetPointeeData()
 - introduced a new CreateValueFromData() method in SBValue that lets you create a new SBValue from a chunk of data wrapped in an SBData
   the limitation to remember for this kind of SBValue is that they have no address: extracting the address-of for these objects (with any
   of GetAddress(), GetLoadAddress() and AddressOf()) will return invalid values
 - added several tests to check that "p"-ing objects (STL classes, char* and char[]) will do the right thing
Solved a bug where global pointers to global variables were not dereferenced correctly for display
New target setting "max-string-summary-length" gives the maximum number of characters to show in a string when summarizing it, instead of the hardcoded 128
Solved a bug where the summary for char[] and char* would not be shown if the ValueObject's were dumped via the "p" command
Removed m_pointers_point_to_load_addrs from ValueObject. Introduced a new m_address_type_of_children, which each ValueObject can set to tell the address type
 of any pointers and/or references it creates. In the current codebase, this is load address most of the time (the only notable exception being file
 addresses that generate file address children UNLESS we have a live process)
Updated help text for summary-string
Fixed an issue in STL formatters where std::stlcontainer::iterator would match the container's synthetic children providers
Edited the syntax and help for some commands to have proper argument types

llvm-svn: 139160

1 files changed, 72 insertions, 0 deletions

diff --git a/lldb/test/functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py b/lldb/test/functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py
index 096a2f5e5d2..bfce217c56f 100644
--- a/lldb/test/functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py
+++ b/lldb/test/functionalities/data-formatter/data-formatter-smart-array/TestDataFormatterSmartArray.py
@@ -79,6 +79,14 @@ class SmartArrayDataFormatterTestCase(TestBase):
                     substrs = ['arr = \"',
                                'Nested Hello world!'])
 
+        self.expect("p strarr",
+                    substrs = ['arr = \"',
+                               'Hello world!'])
+
+        self.expect("p other.strarr",
+                    substrs = ['arr = \"',
+                               'Nested Hello world!'])
+
 # ${var%c}
         self.runCmd("type summary add --summary-string \"ptr = ${var%c}\" \"char *\"")
     
@@ -90,6 +98,14 @@ class SmartArrayDataFormatterTestCase(TestBase):
                 substrs = ['ptr = \"',
                            'Nested Hello world!'])
 
+        self.expect("p strptr",
+                    substrs = ['ptr = \"',
+                               'Hello world!'])
+
+        self.expect("p other.strptr",
+                    substrs = ['ptr = \"',
+                               'Nested Hello world!'])
+
         self.runCmd("type summary add --summary-string \"arr = ${var%c}\" -x \"char \\[[0-9]+\\]\"")
 
         self.expect("frame variable strarr",
@@ -100,6 +116,14 @@ class SmartArrayDataFormatterTestCase(TestBase):
                     substrs = ['arr = \"',
                                'Nested Hello world!'])
         
+        self.expect("p strarr",
+                    substrs = ['arr = \"',
+                               'Hello world!'])
+
+        self.expect("p other.strarr",
+                    substrs = ['arr = \"',
+                               'Nested Hello world!'])
+
 # ${var%char[]}
         self.runCmd("type summary add --summary-string \"arr = ${var%char[]}\" -x \"char \\[[0-9]+\\]\"")
 
@@ -111,6 +135,14 @@ class SmartArrayDataFormatterTestCase(TestBase):
                     substrs = ['arr = ',
                                'Nested Hello world!'])
 
+        self.expect("p strarr",
+                    substrs = ['arr = \"',
+                               'Hello world!'])
+
+        self.expect("p other.strarr",
+                    substrs = ['arr = ',
+                               'Nested Hello world!'])
+
         self.runCmd("type summary add --summary-string \"ptr = ${var%char[]}\" \"char *\"")
 
         self.expect("frame variable strptr",
@@ -121,6 +153,14 @@ class SmartArrayDataFormatterTestCase(TestBase):
             substrs = ['ptr = \"',
             'Nested Hello world!'])
 
+        self.expect("p strptr",
+                    substrs = ['ptr = \"',
+                               'Hello world!'])
+
+        self.expect("p other.strptr",
+                    substrs = ['ptr = \"',
+                               'Nested Hello world!'])
+
 # ${var%a}
         self.runCmd("type summary add --summary-string \"arr = ${var%a}\" -x \"char \\[[0-9]+\\]\"")
 
@@ -132,6 +172,14 @@ class SmartArrayDataFormatterTestCase(TestBase):
                     substrs = ['arr = ',
                                'Nested Hello world!'])
 
+        self.expect("p strarr",
+                    substrs = ['arr = \"',
+                               'Hello world!'])
+
+        self.expect("p other.strarr",
+                    substrs = ['arr = ',
+                               'Nested Hello world!'])
+
         self.runCmd("type summary add --summary-string \"ptr = ${var%a}\" \"char *\"")
 
         self.expect("frame variable strptr",
@@ -142,6 +190,14 @@ class SmartArrayDataFormatterTestCase(TestBase):
                     substrs = ['ptr = \"',
                                'Nested Hello world!'])
 
+        self.expect("p strptr",
+                    substrs = ['ptr = \"',
+                               'Hello world!'])
+
+        self.expect("p other.strptr",
+                    substrs = ['ptr = \"',
+                               'Nested Hello world!'])
+
         self.runCmd("type summary add --summary-string \"ptr = ${var[]%char[]}\" \"char *\"")
         
 # I do not know the size of the data, but you are asking for a full array slice..
@@ -154,6 +210,14 @@ class SmartArrayDataFormatterTestCase(TestBase):
                     substrs = ['ptr = \"',
                                'Nested Hello world!'])
 
+        self.expect("p strptr", matching=False,
+                    substrs = ['ptr = \"',
+                               'Hello world!'])
+
+        self.expect("p other.strptr", matching=False,
+                    substrs = ['ptr = \"',
+                               'Nested Hello world!'])
+
 # You asked an array-style printout...
         self.runCmd("type summary add --summary-string \"ptr = ${var[0-1]%char[]}\" \"char *\"")
         
@@ -165,6 +229,14 @@ class SmartArrayDataFormatterTestCase(TestBase):
                     substrs = ['ptr = ',
                                '[{N},{e}]'])
 
+        self.expect("p strptr",
+                    substrs = ['ptr = ',
+                               '[{H},{e}]'])
+
+        self.expect("p other.strptr",
+                    substrs = ['ptr = ',
+                               '[{N},{e}]'])
+
 # using [] is required here
         self.runCmd("type summary add --summary-string \"arr = ${var%x}\" \"int [5]\"")