diff options
| author | Levon Ter-Grigoryan <patriosthegreat@protonmail.ch> | 2020-01-14 14:33:43 +0100 |
|---|---|---|
| committer | Pavel Labath <pavel@labath.sk> | 2020-01-14 14:59:56 +0100 |
| commit | a705cf1acbe94498f7fcca4e89be6d4820271227 (patch) | |
| tree | 03ae4c768dbec25047a93ef5cee613c7bf8a2f81 /lldb/test/Shell | |
| parent | 77cc690bae310f4cba0a34f2da8a37a7c9a10a82 (diff) | |
| download | bcm5719-llvm-a705cf1acbe94498f7fcca4e89be6d4820271227.tar.gz bcm5719-llvm-a705cf1acbe94498f7fcca4e89be6d4820271227.zip | |
Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions
Summary:
This change is connected with
https://reviews.llvm.org/D69843
In large codebases, we sometimes see Module::FindFunctions (when called from
ClangExpressionDeclMap::FindExternalVisibleDecls) returning huge amounts of
functions.
In current fix I trying to return only function_fullnames from ManualDWARFIndex::GetFunctions when eFunctionNameTypeFull is passed as argument.
Reviewers: labath, jarin, aprantl
Reviewed By: labath
Subscribers: shafik, clayborg, teemperor, arphaman, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70846
Diffstat (limited to 'lldb/test/Shell')
| -rw-r--r-- | lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp | 20 |
1 files changed, 11 insertions, 9 deletions
diff --git a/lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp b/lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp index 3d175f63e04..a05b0685a3d 100644 --- a/lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp +++ b/lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp @@ -21,7 +21,7 @@ // RUN: lldb-test symbols --name=foo --find=function --function-flags=method %t | \ // RUN: FileCheck --check-prefix=METHOD %s // RUN: lldb-test symbols --name=foo --find=function --function-flags=full %t | \ -// RUN: FileCheck --check-prefix=FULL %s +// RUN: FileCheck --check-prefix=FULL-APPLE %s // RUN: lldb-test symbols --name=_Z3fooi --find=function --function-flags=full %t | \ // RUN: FileCheck --check-prefix=FULL-MANGLED %s // RUN: lldb-test symbols --name=foo --context=context --find=function --function-flags=base %t | \ @@ -55,14 +55,16 @@ // METHOD-DAG: name = "sbar::foo(int)", mangled = "_ZN4sbar3fooEi" // METHOD-DAG: name = "ffbar()::sbaz::foo()", mangled = "_ZZ5ffbarvEN4sbaz3fooEv" -// FULL: Found 7 functions: -// FULL-DAG: name = "foo()", mangled = "_Z3foov" -// FULL-DAG: name = "foo(int)", mangled = "_Z3fooi" -// FULL-DAG: name = "bar::foo()", mangled = "_ZN3bar3fooEv" -// FULL-DAG: name = "bar::baz::foo()", mangled = "_ZN3bar3baz3fooEv" -// FULL-DAG: name = "sbar::foo()", mangled = "_ZN4sbar3fooEv" -// FULL-DAG: name = "sbar::foo(int)", mangled = "_ZN4sbar3fooEi" -// FULL-DAG: name = "ffbar()::sbaz::foo()", mangled = "_ZZ5ffbarvEN4sbaz3fooEv" +// FULL-APPLE: Found 7 functions: +// FULL-APPLE-DAG: name = "foo()", mangled = "_Z3foov" +// FULL-APPLE-DAG: name = "foo(int)", mangled = "_Z3fooi" +// FULL-APPLE-DAG: name = "bar::foo()", mangled = "_ZN3bar3fooEv" +// FULL-APPLE-DAG: name = "bar::baz::foo()", mangled = "_ZN3bar3baz3fooEv" +// FULL-APPLE-DAG: name = "sbar::foo()", mangled = "_ZN4sbar3fooEv" +// FULL-APPLE-DAG: name = "sbar::foo(int)", mangled = "_ZN4sbar3fooEi" +// FULL-APPLE-DAG: name = "ffbar()::sbaz::foo()", mangled = "_ZZ5ffbarvEN4sbaz3fooEv" + +// FULL: Found 0 functions: // FULL-MANGLED: Found 1 functions: // FULL-MANGLED-DAG: name = "foo(int)", mangled = "_Z3fooi" |
