diff options
| author | Pavel Labath <pavel@labath.sk> | 2019-11-14 15:31:26 +0100 |
|---|---|---|
| committer | Pavel Labath <pavel@labath.sk> | 2019-11-26 14:24:28 +0100 |
| commit | 957d9a0335b8199b01caec56574e72154c3a1226 (patch) | |
| tree | ef7e22f5d85a5e40167cee80f15df9fd852cf13f /lldb/test/Shell/SymbolFile | |
| parent | 9b06897009dc32313354559c969d6cf0a564ec06 (diff) | |
| download | bcm5719-llvm-957d9a0335b8199b01caec56574e72154c3a1226.tar.gz bcm5719-llvm-957d9a0335b8199b01caec56574e72154c3a1226.zip | |
[lldb] remove unsigned Stream::operator<< overloads
Summary:
I recently re-discovered that the unsinged stream operators of the
lldb_private::Stream class have a surprising behavior in that they print
the number in hex. This is all the more confusing because the "signed"
versions of those operators behave normally.
Now that, thanks to Raphael, each Stream class has a llvm::raw_ostream
wrapper, I think we should delete most of our formatting capabilities
and just delegate to that. This patch tests the water by just deleting
the operators with the most surprising behavior.
Most of the code using these operators was printing user_id_t values. It
wasn't fully consistent about prefixing them with "0x", but I've tried
to consistenly print it without that prefix, to make it more obviously
different from pointer values.
Reviewers: teemperor, JDevlieghere, jdoerfert
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70241
Diffstat (limited to 'lldb/test/Shell/SymbolFile')
| -rw-r--r-- | lldb/test/Shell/SymbolFile/DWARF/array-sizes.s | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/test/Shell/SymbolFile/DWARF/array-sizes.s b/lldb/test/Shell/SymbolFile/DWARF/array-sizes.s index f00fe2ad005..b810527b553 100644 --- a/lldb/test/Shell/SymbolFile/DWARF/array-sizes.s +++ b/lldb/test/Shell/SymbolFile/DWARF/array-sizes.s @@ -10,7 +10,7 @@ # RUN: lldb-test symbols %t | FileCheck %s # CHECK: Variable{0x7fffffff0000001e}, name = "X" -# CHECK-SAME: type = {7fffffff00000033} 0x{{[0-9a-f]*}} (char [56]) +# CHECK-SAME: type = {7fffffff00000033} 0x{{[0-9A-F]*}} (char [56]) # Generated from "char X[47];" |
