diff options
| author | Adrian Prantl <aprantl@apple.com> | 2019-12-10 14:29:13 -0800 |
|---|---|---|
| committer | Adrian Prantl <aprantl@apple.com> | 2019-12-10 16:11:10 -0800 |
| commit | 2fb07b90dc1c2c08fe6fc69c9d569a1fc2c8a8e1 (patch) | |
| tree | d64a460b2c924972c40e951d9ad587d4fda51a56 /lldb/source | |
| parent | b3801de7c50faa2b730e62e1cfabeec8c5cebae2 (diff) | |
| download | bcm5719-llvm-2fb07b90dc1c2c08fe6fc69c9d569a1fc2c8a8e1.tar.gz bcm5719-llvm-2fb07b90dc1c2c08fe6fc69c9d569a1fc2c8a8e1.zip | |
Remove unsound caching in LanguageCategory
Analogous to https://reviews.llvm.org/D71233 it is not safe to cache
something that depends on the actual ValueObject in a cache then keys
only off the type name.
Differential Revision: https://reviews.llvm.org/D71297
Diffstat (limited to 'lldb/source')
| -rw-r--r-- | lldb/source/DataFormatters/LanguageCategory.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/lldb/source/DataFormatters/LanguageCategory.cpp b/lldb/source/DataFormatters/LanguageCategory.cpp index 78237e18fb2..d4d8bb9cc8d 100644 --- a/lldb/source/DataFormatters/LanguageCategory.cpp +++ b/lldb/source/DataFormatters/LanguageCategory.cpp @@ -110,10 +110,6 @@ bool LanguageCategory::GetHardcoded(FormatManager &fmt_mgr, break; } } - if (match_data.GetTypeForCache() && - (!retval_sp || !retval_sp->NonCacheable())) { - m_format_cache.Set(match_data.GetTypeForCache(), retval_sp); - } return (bool)retval_sp; } |
