Delete Host/windows/win32.h

It's always hard to remember when to include this file, and
when you do include it it's hard to remember what preprocessor
check it needs to be behind, and then you further have to remember
whether it's windows.h or win32.h which you need to include.

This patch changes the name to PosixApi.h, which is more appropriately
named, and makes it independent of any preprocessor setting.

There's still the issue of people not knowing when to include this,
because there's not a well-defined set of things it exposes other
than "whatever is missing on Windows", but at least this should
make it less painful to fix when problems arise.

This patch depends on LLVM revision r278170.

llvm-svn: 278177

2 files changed, 3 insertions, 14 deletions

diff --git a/lldb/source/Utility/PseudoTerminal.cpp b/lldb/source/Utility/PseudoTerminal.cpp
index 94c75daa873..7a200f2a817 100644
--- a/lldb/source/Utility/PseudoTerminal.cpp
+++ b/lldb/source/Utility/PseudoTerminal.cpp
@@ -18,21 +18,9 @@
 #include <sys/ioctl.h>
 #endif
 
-#ifdef _WIN32
-#include "lldb/Host/windows/win32.h"
-typedef uint32_t pid_t;
-// empty functions
-int posix_openpt(int flag) { return 0; }
+#include "lldb/Host/PosixApi.h"
 
-int strerror_r(int errnum, char *buf, size_t buflen) { return 0; }
-
-int unlockpt(int fd) { return 0; }
-int grantpt(int fd) { return 0; }
-char *ptsname(int fd) { return 0; }
-
-pid_t fork(void) { return 0; }
-pid_t setsid(void) { return 0; }
-#elif defined(__ANDROID_NDK__)
+#if defined(__ANDROID_NDK__)
 int posix_openpt(int flags);
 #endif
 
diff --git a/lldb/source/Utility/TimeSpecTimeout.h b/lldb/source/Utility/TimeSpecTimeout.h
index 388ccc179c1..8f809ace3c9 100644
--- a/lldb/source/Utility/TimeSpecTimeout.h
+++ b/lldb/source/Utility/TimeSpecTimeout.h
@@ -10,6 +10,7 @@
 #ifndef utility_TimeSpecTimeout_h_
 #define utility_TimeSpecTimeout_h_
 
+#include "lldb/Host/PosixApi.h"
 #include "lldb/Host/TimeValue.h"
 
 namespace lldb_private {