diff options
author | Jonas Devlieghere <jonas@devlieghere.com> | 2019-04-10 20:48:55 +0000 |
---|---|---|
committer | Jonas Devlieghere <jonas@devlieghere.com> | 2019-04-10 20:48:55 +0000 |
commit | 8b3af63b8993e45b1783853a3fcf6f36bfbed81b (patch) | |
tree | 41759d08361beda32b90e345d8033aecd2e15088 /lldb/source/Utility/DataBufferHeap.cpp | |
parent | 66b6bb1766b3e5eea56b26fc91d03f1fccbe15e4 (diff) | |
download | bcm5719-llvm-8b3af63b8993e45b1783853a3fcf6f36bfbed81b.tar.gz bcm5719-llvm-8b3af63b8993e45b1783853a3fcf6f36bfbed81b.zip |
[NFC] Remove ASCII lines from comments
A lot of comments in LLDB are surrounded by an ASCII line to delimit the
begging and end of the comment.
Its use is not really consistent across the code base, sometimes the
lines are longer, sometimes they are shorter and sometimes they are
omitted. Furthermore, it looks kind of weird with the 80 column limit,
where the comment actually extends past the line, but not by much.
Furthermore, when /// is used for Doxygen comments, it looks
particularly odd. And when // is used, it incorrectly gives the
impression that it's actually a Doxygen comment.
I assume these lines were added to improve distinguishing between
comments and code. However, given that todays editors and IDEs do a
great job at highlighting comments, I think it's worth to drop this for
the sake of consistency. The alternative is fixing all the
inconsistencies, which would create a lot more churn.
Differential revision: https://reviews.llvm.org/D60508
llvm-svn: 358135
Diffstat (limited to 'lldb/source/Utility/DataBufferHeap.cpp')
-rw-r--r-- | lldb/source/Utility/DataBufferHeap.cpp | 16 |
1 files changed, 0 insertions, 16 deletions
diff --git a/lldb/source/Utility/DataBufferHeap.cpp b/lldb/source/Utility/DataBufferHeap.cpp index 5406cb97fe3..baefe4159ad 100644 --- a/lldb/source/Utility/DataBufferHeap.cpp +++ b/lldb/source/Utility/DataBufferHeap.cpp @@ -11,57 +11,41 @@ using namespace lldb_private; -//---------------------------------------------------------------------- // Default constructor -//---------------------------------------------------------------------- DataBufferHeap::DataBufferHeap() : m_data() {} -//---------------------------------------------------------------------- // Initialize this class with "n" characters and fill the buffer with "ch". -//---------------------------------------------------------------------- DataBufferHeap::DataBufferHeap(lldb::offset_t n, uint8_t ch) : m_data() { if (n < m_data.max_size()) m_data.assign(n, ch); } -//---------------------------------------------------------------------- // Initialize this class with a copy of the "n" bytes from the "bytes" buffer. -//---------------------------------------------------------------------- DataBufferHeap::DataBufferHeap(const void *src, lldb::offset_t src_len) : m_data() { CopyData(src, src_len); } -//---------------------------------------------------------------------- // Virtual destructor since this class inherits from a pure virtual base class. -//---------------------------------------------------------------------- DataBufferHeap::~DataBufferHeap() = default; -//---------------------------------------------------------------------- // Return a pointer to the bytes owned by this object, or nullptr if the object // contains no bytes. -//---------------------------------------------------------------------- uint8_t *DataBufferHeap::GetBytes() { return (m_data.empty() ? nullptr : m_data.data()); } -//---------------------------------------------------------------------- // Return a const pointer to the bytes owned by this object, or nullptr if the // object contains no bytes. -//---------------------------------------------------------------------- const uint8_t *DataBufferHeap::GetBytes() const { return (m_data.empty() ? nullptr : m_data.data()); } -//---------------------------------------------------------------------- // Return the number of bytes this object currently contains. -//---------------------------------------------------------------------- uint64_t DataBufferHeap::GetByteSize() const { return m_data.size(); } -//---------------------------------------------------------------------- // Sets the number of bytes that this object should be able to contain. This // can be used prior to copying data into the buffer. -//---------------------------------------------------------------------- uint64_t DataBufferHeap::SetByteSize(uint64_t new_size) { m_data.resize(new_size); return m_data.size(); |