diff options
| author | Davide Italiano <ditaliano@apple.com> | 2019-12-03 16:54:04 -0800 |
|---|---|---|
| committer | Davide Italiano <ditaliano@apple.com> | 2019-12-03 16:54:55 -0800 |
| commit | cec82634a4034b1528940487349be14b0c405d2d (patch) | |
| tree | f7a3f5e1e97d43302fc1085e17bc45f30d15aa02 /lldb/source/Target | |
| parent | b0df90488ce9c703d1bbc3d02c4b29e85d0f706b (diff) | |
| download | bcm5719-llvm-cec82634a4034b1528940487349be14b0c405d2d.tar.gz bcm5719-llvm-cec82634a4034b1528940487349be14b0c405d2d.zip | |
[Process] GetLanguageRuntimes() takes an argument that's always constant.
And arguably `retry_if_null` isn't really descriptive of what
the flag did anyway.
Diffstat (limited to 'lldb/source/Target')
| -rw-r--r-- | lldb/source/Target/Process.cpp | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp index ed0b951fbce..a731a353c1b 100644 --- a/lldb/source/Target/Process.cpp +++ b/lldb/source/Target/Process.cpp @@ -1486,8 +1486,7 @@ const lldb::ABISP &Process::GetABI() { return m_abi_sp; } -std::vector<LanguageRuntime *> -Process::GetLanguageRuntimes(bool retry_if_null) { +std::vector<LanguageRuntime *> Process::GetLanguageRuntimes() { std::vector<LanguageRuntime *> language_runtimes; if (m_finalizing) @@ -1500,15 +1499,14 @@ Process::GetLanguageRuntimes(bool retry_if_null) { // yet or the proper condition for loading wasn't yet met (e.g. libc++.so // hadn't been loaded). for (const lldb::LanguageType lang_type : Language::GetSupportedLanguages()) { - if (LanguageRuntime *runtime = GetLanguageRuntime(lang_type, retry_if_null)) + if (LanguageRuntime *runtime = GetLanguageRuntime(lang_type)) language_runtimes.emplace_back(runtime); } return language_runtimes; } -LanguageRuntime *Process::GetLanguageRuntime(lldb::LanguageType language, - bool retry_if_null) { +LanguageRuntime *Process::GetLanguageRuntime(lldb::LanguageType language) { if (m_finalizing) return nullptr; @@ -1517,7 +1515,7 @@ LanguageRuntime *Process::GetLanguageRuntime(lldb::LanguageType language, std::lock_guard<std::recursive_mutex> guard(m_language_runtimes_mutex); LanguageRuntimeCollection::iterator pos; pos = m_language_runtimes.find(language); - if (pos == m_language_runtimes.end() || (retry_if_null && !pos->second)) { + if (pos == m_language_runtimes.end() || !pos->second) { lldb::LanguageRuntimeSP runtime_sp( LanguageRuntime::FindPlugin(this, language)); |

