diff options
author | Zachary Turner <zturner@google.com> | 2019-01-14 22:41:21 +0000 |
---|---|---|
committer | Zachary Turner <zturner@google.com> | 2019-01-14 22:41:21 +0000 |
commit | 576495e67b3c7d3d2f98e7af312cb03e8f63f1cd (patch) | |
tree | d460cc909087c236c8dd77857296b903580f8505 /lldb/source/Target | |
parent | c0a246afbe03b8f1d52e06267e9c2a5f2c4521ff (diff) | |
download | bcm5719-llvm-576495e67b3c7d3d2f98e7af312cb03e8f63f1cd.tar.gz bcm5719-llvm-576495e67b3c7d3d2f98e7af312cb03e8f63f1cd.zip |
[SymbolFile] Remove SymbolContext parameter from FindTypes.
This parameter was only ever used with the Module set, and
since a SymbolFile is tied to a module, the parameter turns
out to be entirely unnecessary. Furthermore, it doesn't make
a lot of sense to ask a caller to ask SymbolFile which is tied
to Module X to find types for Module Y, but that possibility
was open with the previous interface. By removing this
parameter from the API, it makes it harder to use incorrectly
as well as easier for an implementor to understand what it
needs to do.
llvm-svn: 351133
Diffstat (limited to 'lldb/source/Target')
-rw-r--r-- | lldb/source/Target/Language.cpp | 3 | ||||
-rw-r--r-- | lldb/source/Target/ObjCLanguageRuntime.cpp | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/lldb/source/Target/Language.cpp b/lldb/source/Target/Language.cpp index 599b4422274..5c7a4097dd6 100644 --- a/lldb/source/Target/Language.cpp +++ b/lldb/source/Target/Language.cpp @@ -385,11 +385,10 @@ bool Language::ImageListTypeScavenger::Find_Impl( Target *target = exe_scope->CalculateTarget().get(); if (target) { const auto &images(target->GetImages()); - SymbolContext null_sc; ConstString cs_key(key); llvm::DenseSet<SymbolFile *> searched_sym_files; TypeList matches; - images.FindTypes(null_sc, cs_key, false, UINT32_MAX, searched_sym_files, + images.FindTypes(nullptr, cs_key, false, UINT32_MAX, searched_sym_files, matches); for (const auto &match : matches.Types()) { if (match.get()) { diff --git a/lldb/source/Target/ObjCLanguageRuntime.cpp b/lldb/source/Target/ObjCLanguageRuntime.cpp index b1fcee6db63..8627da938ea 100644 --- a/lldb/source/Target/ObjCLanguageRuntime.cpp +++ b/lldb/source/Target/ObjCLanguageRuntime.cpp @@ -108,14 +108,13 @@ ObjCLanguageRuntime::LookupInCompleteClassCache(ConstString &name) { if (!module_sp) return TypeSP(); - const SymbolContext null_sc; const bool exact_match = true; const uint32_t max_matches = UINT32_MAX; TypeList types; llvm::DenseSet<SymbolFile *> searched_symbol_files; const uint32_t num_types = module_sp->FindTypes( - null_sc, name, exact_match, max_matches, searched_symbol_files, types); + name, exact_match, max_matches, searched_symbol_files, types); if (num_types) { uint32_t i; |