diff options
| author | Bruce Mitchener <bruce.mitchener@gmail.com> | 2015-05-08 09:28:11 +0000 |
|---|---|---|
| committer | Bruce Mitchener <bruce.mitchener@gmail.com> | 2015-05-08 09:28:11 +0000 |
| commit | 3a6cc51cb90cba16c4485412b71964c89dcb8cd4 (patch) | |
| tree | d881727eb419076f00348628fe7c1f72b0b8774e /lldb/source/Target | |
| parent | 42544d64721bfbfd99832165cd8660ef860841ed (diff) | |
| download | bcm5719-llvm-3a6cc51cb90cba16c4485412b71964c89dcb8cd4.tar.gz bcm5719-llvm-3a6cc51cb90cba16c4485412b71964c89dcb8cd4.zip | |
Make LLDB-MI tests wait for LLDB-MI to start up before sending any MI commands
Summary:
This set of changes addresses the issue I described in [[ http://llvm.org/pr23403 | Bug 23403 ]], in short most LLDB-MI tests fail unexpectedly due to timeout on my Ubuntu 14.10 x86_64 VirtualBox VM. I have no idea why the Ubuntu buildbots don't seem to suffer from this issue. This patch just makes **MiTestCaseBase.spawnLldbMi()** block until the spawned LLDB-MI child process outputs the **(gdb)** prompt, which ensures that MI commands aren't sent to the LLDB-MI child process until it's ready.
Before these changes 52 LLDB-MI tests failed unexpectedly (all but one due to timeouts), after these changes no tests fail due to timeouts. I still get one unexpected failure in **test_lldbmi_source_option_start_script_error** in **TestMiStartupOptions.py**, but that's due to a file error, that test should be skipped on Linux just like the other two //start_script// tests until the file error is fixed.
Patch from Vadim Macagon. Thanks!
Test Plan: ./dotest.py -A x86_64 -C clang --executable $BUILDDIR/bin/lldb tools/lldb-mi/
Reviewers: abidh, domipheus, ki.stfu
Reviewed By: ki.stfu
Subscribers: brucem, lldb-commits
Differential Revision: http://reviews.llvm.org/D9595
llvm-svn: 236816
Diffstat (limited to 'lldb/source/Target')
0 files changed, 0 insertions, 0 deletions

