diff options
| author | Pavel Labath <pavel@labath.sk> | 2019-11-28 17:02:07 +0100 |
|---|---|---|
| committer | Pavel Labath <pavel@labath.sk> | 2019-12-04 10:49:25 +0100 |
| commit | 28e4942b2c3b8961b91b362b4b76b9ca0f735cc2 (patch) | |
| tree | 3e20ed9cbdfb907f0d0d8ef099fc149175167fe0 /lldb/source/Target | |
| parent | 16d20130444c9601ad276a8e82f79b2ac204c6f6 (diff) | |
| download | bcm5719-llvm-28e4942b2c3b8961b91b362b4b76b9ca0f735cc2.tar.gz bcm5719-llvm-28e4942b2c3b8961b91b362b4b76b9ca0f735cc2.zip | |
[lldb] Remove FileSpec(FileSpec*) constructor
This constructor was the cause of some pretty weird behavior. Remove it,
and update all code to properly dereference the argument instead.
Diffstat (limited to 'lldb/source/Target')
| -rw-r--r-- | lldb/source/Target/Target.cpp | 7 |
1 files changed, 3 insertions, 4 deletions
diff --git a/lldb/source/Target/Target.cpp b/lldb/source/Target/Target.cpp index ed76e753b17..01b9a92cafc 100644 --- a/lldb/source/Target/Target.cpp +++ b/lldb/source/Target/Target.cpp @@ -404,8 +404,8 @@ Target::CreateAddressInModuleBreakpoint(lldb::addr_t file_addr, bool internal, bool request_hardware) { SearchFilterSP filter_sp( new SearchFilterForUnconstrainedSearches(shared_from_this())); - BreakpointResolverSP resolver_sp( - new BreakpointResolverAddress(nullptr, file_addr, file_spec)); + BreakpointResolverSP resolver_sp(new BreakpointResolverAddress( + nullptr, file_addr, file_spec ? *file_spec : FileSpec())); return CreateBreakpoint(filter_sp, resolver_sp, internal, request_hardware, false); } @@ -1425,8 +1425,7 @@ void Target::SetExecutableModule(ModuleSP &executable_sp, ModuleList added_modules; executable_objfile->GetDependentModules(dependent_files); for (uint32_t i = 0; i < dependent_files.GetSize(); i++) { - FileSpec dependent_file_spec( - dependent_files.GetFileSpecPointerAtIndex(i)); + FileSpec dependent_file_spec(dependent_files.GetFileSpecAtIndex(i)); FileSpec platform_dependent_file_spec; if (m_platform_sp) m_platform_sp->GetFileWithUUID(dependent_file_spec, nullptr, |
