diff options
author | Jim Ingham <jingham@apple.com> | 2013-05-08 00:35:16 +0000 |
---|---|---|
committer | Jim Ingham <jingham@apple.com> | 2013-05-08 00:35:16 +0000 |
commit | 221d51cf84699af9c182ed4a4eb8850a75512711 (patch) | |
tree | 3d8e9d36039497fc43ac2a0b52dce7a7acb78481 /lldb/source/Target/ThreadPlanStepThrough.cpp | |
parent | 6156011ee81b08d58524666fb22f8586aaa406bf (diff) | |
download | bcm5719-llvm-221d51cf84699af9c182ed4a4eb8850a75512711.tar.gz bcm5719-llvm-221d51cf84699af9c182ed4a4eb8850a75512711.zip |
Figure out the reply to "PlanExplainsStop" once when we stop and then use the cached
value. This fixes problems, for instance, with the StepRange plans, where they know that
they explained the stop because they were at their "run to here" breakpoint, then deleted
that breakpoint, so when they got asked again, doh! I had done this for a couple of plans
in an ad hoc fashion, this just formalizes it.
Also add a "ResumeRequested" in Process so that the code in the completion handlers can
tell the ShouldStop logic they want to resume rather than just directly resuming. That allows
us to handle resuming in a more controlled fashion.
Also, SetPublicState can take a "restarted" flag, so that it doesn't drop the run lock when
the target was immediately restarted.
--This line, and those below , will be ignored--
M test/lang/objc/objc-dynamic-value/TestObjCDynamicValue.py
M include/lldb/Target/ThreadList.h
M include/lldb/Target/ThreadPlanStepOut.h
M include/lldb/Target/Thread.h
M include/lldb/Target/ThreadPlanBase.h
M include/lldb/Target/ThreadPlanStepThrough.h
M include/lldb/Target/ThreadPlanStepInstruction.h
M include/lldb/Target/ThreadPlanStepInRange.h
M include/lldb/Target/ThreadPlanStepOverBreakpoint.h
M include/lldb/Target/ThreadPlanStepUntil.h
M include/lldb/Target/StopInfo.h
M include/lldb/Target/Process.h
M include/lldb/Target/ThreadPlanRunToAddress.h
M include/lldb/Target/ThreadPlan.h
M include/lldb/Target/ThreadPlanCallFunction.h
M include/lldb/Target/ThreadPlanStepOverRange.h
M source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.h
M source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp
M source/Target/StopInfo.cpp
M source/Target/Process.cpp
M source/Target/ThreadPlanRunToAddress.cpp
M source/Target/ThreadPlan.cpp
M source/Target/ThreadPlanCallFunction.cpp
M source/Target/ThreadPlanStepOverRange.cpp
M source/Target/ThreadList.cpp
M source/Target/ThreadPlanStepOut.cpp
M source/Target/Thread.cpp
M source/Target/ThreadPlanBase.cpp
M source/Target/ThreadPlanStepThrough.cpp
M source/Target/ThreadPlanStepInstruction.cpp
M source/Target/ThreadPlanStepInRange.cpp
M source/Target/ThreadPlanStepOverBreakpoint.cpp
M source/Target/ThreadPlanStepUntil.cpp
M lldb.xcodeproj/xcshareddata/xcschemes/Run Testsuite.xcscheme
llvm-svn: 181381
Diffstat (limited to 'lldb/source/Target/ThreadPlanStepThrough.cpp')
-rw-r--r-- | lldb/source/Target/ThreadPlanStepThrough.cpp | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/lldb/source/Target/ThreadPlanStepThrough.cpp b/lldb/source/Target/ThreadPlanStepThrough.cpp index d6dab171037..92d1fcd850d 100644 --- a/lldb/source/Target/ThreadPlanStepThrough.cpp +++ b/lldb/source/Target/ThreadPlanStepThrough.cpp @@ -139,7 +139,7 @@ ThreadPlanStepThrough::ValidatePlan (Stream *error) } bool -ThreadPlanStepThrough::PlanExplainsStop (Event *event_ptr) +ThreadPlanStepThrough::DoPlanExplainsStop (Event *event_ptr) { // If we have a sub-plan, it will have been asked first if we explain the stop, and // we won't get asked. The only time we would be the one directly asked this question @@ -223,9 +223,8 @@ ThreadPlanStepThrough::GetPlanRunState () } bool -ThreadPlanStepThrough::WillResume (StateType resume_state, bool current_plan) +ThreadPlanStepThrough::DoWillResume (StateType resume_state, bool current_plan) { - ThreadPlan::WillResume(resume_state, current_plan); return true; } |