summaryrefslogtreecommitdiffstats
path: root/lldb/source/Target/ThreadPlanStepInRange.cpp
diff options
context:
space:
mode:
authorEd Maste <emaste@freebsd.org>2013-11-25 16:36:47 +0000
committerEd Maste <emaste@freebsd.org>2013-11-25 16:36:47 +0000
commit6cf5b8f18c80974225465cc4a23e3688f84c8af1 (patch)
tree6b0aa7df4de5060fa55a6819291d1060405aa3cb /lldb/source/Target/ThreadPlanStepInRange.cpp
parent502f9020a7fc8ca9a1f6b7626acdc118964af806 (diff)
downloadbcm5719-llvm-6cf5b8f18c80974225465cc4a23e3688f84c8af1.tar.gz
bcm5719-llvm-6cf5b8f18c80974225465cc4a23e3688f84c8af1.zip
Fix issue from r166732 found by Andrew Kaylor
From Jim Ingham's email: It does look like ThreadPlanStepInRange test is some kind of thinko. In practice, in this case it is probably safe to run only one thread when doing the "step through" since that generally involved running from a shared library stub to its target. That could deadlock if the dynamic loader has to fix up the symbol, and another thread is in the middle of doing that. But that doesn't seem to be very common, or at least the code is clearly wrong but I haven't had any reports of this causing deadlocks... llvm-svn: 195657
Diffstat (limited to 'lldb/source/Target/ThreadPlanStepInRange.cpp')
-rw-r--r--lldb/source/Target/ThreadPlanStepInRange.cpp4
1 files changed, 2 insertions, 2 deletions
diff --git a/lldb/source/Target/ThreadPlanStepInRange.cpp b/lldb/source/Target/ThreadPlanStepInRange.cpp
index c1f14bd216d..2cfd29f8919 100644
--- a/lldb/source/Target/ThreadPlanStepInRange.cpp
+++ b/lldb/source/Target/ThreadPlanStepInRange.cpp
@@ -132,9 +132,9 @@ ThreadPlanStepInRange::ShouldStop (Event *event_ptr)
bool stop_others;
if (m_stop_others == lldb::eOnlyThisThread)
- stop_others = false;
- else
stop_others = true;
+ else
+ stop_others = false;
FrameComparison frame_order = CompareCurrentFrameToStartFrame();
OpenPOWER on IntegriCloud