<rdar://problem/10103468>

I started work on being able to add symbol files after a debug session
had started with a new "target symfile add" command and quickly ran into
problems with stale Address objects in breakpoint locations that had 
lldb_private::Section pointers into modules that had been removed or 
replaced. This also let to grabbing stale modules from those sections. 
So I needed to thread harded the Address, Section and related objects.

To do this I modified the ModuleChild class to now require a ModuleSP
on initialization so that a weak reference can created. I also changed
all places that were handing out "Section *" to have them hand out SectionSP.
All ObjectFile, SymbolFile and SymbolVendors were inheriting from ModuleChild
so all of the find plug-in, static creation function and constructors now
require ModuleSP references instead of Module *. 

Address objects now have weak references to their sections which can
safely go stale when a module gets destructed. 

This checkin doesn't complete the "target symfile add" command, but it
does get us a lot clioser to being able to do such things without a high
risk of crashing or memory corruption.

llvm-svn: 151336

1 files changed, 6 insertions, 6 deletions

diff --git a/lldb/source/Symbol/SymbolVendor.cpp b/lldb/source/Symbol/SymbolVendor.cpp
index 90ea65bac19..1b03eb5e996 100644
--- a/lldb/source/Symbol/SymbolVendor.cpp
+++ b/lldb/source/Symbol/SymbolVendor.cpp
@@ -30,7 +30,7 @@ using namespace lldb_private;
 // also allow for finding separate debug information files.
 //----------------------------------------------------------------------
 SymbolVendor*
-SymbolVendor::FindPlugin (Module* module)
+SymbolVendor::FindPlugin (const lldb::ModuleSP &module_sp)
 {
     std::auto_ptr<SymbolVendor> instance_ap;
     //----------------------------------------------------------------------
@@ -39,7 +39,7 @@ SymbolVendor::FindPlugin (Module* module)
     SymbolVendorCreateInstance create_callback;
     for (uint32_t idx = 0; (create_callback = PluginManager::GetSymbolVendorCreateCallbackAtIndex(idx)) != NULL; ++idx)
     {
-        instance_ap.reset(create_callback(module));
+        instance_ap.reset(create_callback(module_sp));
 
         if (instance_ap.get())
         {
@@ -53,10 +53,10 @@ SymbolVendor::FindPlugin (Module* module)
     }
     // The default implementation just tries to create debug information using the
     // file representation for the module.
-    instance_ap.reset(new SymbolVendor(module));
+    instance_ap.reset(new SymbolVendor(module_sp));
     if (instance_ap.get())
     {
-        ObjectFile *objfile = module->GetObjectFile();
+        ObjectFile *objfile = module_sp->GetObjectFile();
         if (objfile)
             instance_ap->AddSymbolFileRepresentation(objfile->shared_from_this());
     }
@@ -66,8 +66,8 @@ SymbolVendor::FindPlugin (Module* module)
 //----------------------------------------------------------------------
 // SymbolVendor constructor
 //----------------------------------------------------------------------
-SymbolVendor::SymbolVendor(Module *module) :
-    ModuleChild(module),
+SymbolVendor::SymbolVendor(const lldb::ModuleSP &module_sp) :
+    ModuleChild (module_sp),
     m_mutex (Mutex::eMutexTypeRecursive),
     m_type_list(),
     m_compile_units(),