<rdar://problem/10103468>

I started work on being able to add symbol files after a debug session
had started with a new "target symfile add" command and quickly ran into
problems with stale Address objects in breakpoint locations that had 
lldb_private::Section pointers into modules that had been removed or 
replaced. This also let to grabbing stale modules from those sections. 
So I needed to thread harded the Address, Section and related objects.

To do this I modified the ModuleChild class to now require a ModuleSP
on initialization so that a weak reference can created. I also changed
all places that were handing out "Section *" to have them hand out SectionSP.
All ObjectFile, SymbolFile and SymbolVendors were inheriting from ModuleChild
so all of the find plug-in, static creation function and constructors now
require ModuleSP references instead of Module *. 

Address objects now have weak references to their sections which can
safely go stale when a module gets destructed. 

This checkin doesn't complete the "target symfile add" command, but it
does get us a lot clioser to being able to do such things without a high
risk of crashing or memory corruption.

llvm-svn: 151336

1 files changed, 7 insertions, 7 deletions

diff --git a/lldb/source/Symbol/Function.cpp b/lldb/source/Symbol/Function.cpp
index 1297fd96fb3..1fddd18afc8 100644
--- a/lldb/source/Symbol/Function.cpp
+++ b/lldb/source/Symbol/Function.cpp
@@ -385,17 +385,17 @@ Function::CalculateSymbolContext(SymbolContext* sc)
     m_comp_unit->CalculateSymbolContext(sc);
 }
 
-Module *
+ModuleSP
 Function::CalculateSymbolContextModule ()
 {
-    const Section *section = m_range.GetBaseAddress().GetSection();
-    if (section)
+    SectionSP section_sp (m_range.GetBaseAddress().GetSection());
+    if (section_sp)
     {
-        const Section *linked_section = section->GetLinkedSection();
-        if (linked_section)
-            return linked_section->GetModule();
+        SectionSP linked_section_sp (section_sp->GetLinkedSection());
+        if (linked_section_sp)
+            return linked_section_sp->GetModule();
         else
-            return section->GetModule();
+            return section_sp->GetModule();
     }
     
     return this->GetCompileUnit()->GetModule();