[NativePDB] Implement ParseDeclsForContext.

This is a first step towards getting lldb-test symbols working
with the native plugin.  There is a remaining issue, which is
that the plugin expects that ParseDeclsForContext will also
create lldb symbols rather than just the decls, but the native
pdb plugin doesn't currently do this.  This will be addressed
in a followup patch.

llvm-svn: 350243

1 files changed, 1 insertions, 9 deletions

diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/PdbIndex.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/PdbIndex.cpp
index 40a4b5ccdf4..51a3d106180 100644
--- a/lldb/source/Plugins/SymbolFile/NativePDB/PdbIndex.cpp
+++ b/lldb/source/Plugins/SymbolFile/NativePDB/PdbIndex.cpp
@@ -136,15 +136,7 @@ void PdbIndex::BuildAddrToSymbolMap(CompilandIndexItem &cci) {
     // If the debug info is incorrect, we could have multiple symbols with the
     // same address.  So use try_emplace instead of insert, and the first one
     // will win.
-    auto insert_result =
-        cci.m_symbols_by_va.insert(std::make_pair(va, PdbSymUid(cu_sym_id)));
-    (void)insert_result;
-
-    // The odds of an error in some function such as GetSegmentAndOffset or
-    // MakeVirtualAddress are much higher than the odds of encountering bad
-    // debug info, so assert that this item was inserted in the map as opposed
-    // to having already been there.
-    lldbassert(insert_result.second);
+    cci.m_symbols_by_va.try_emplace(va, PdbSymUid(cu_sym_id));
   }
 }