diff options
author | Pavel Labath <pavel@labath.sk> | 2019-08-27 07:49:41 +0000 |
---|---|---|
committer | Pavel Labath <pavel@labath.sk> | 2019-08-27 07:49:41 +0000 |
commit | e588b8b66456e2eae0c970da5b25bee32a280b48 (patch) | |
tree | 80a79f18d975fd8bf1d61452de6d96cdee025276 /lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp | |
parent | 3131aed59bb1465253642c26bcff357524b7dd2c (diff) | |
download | bcm5719-llvm-e588b8b66456e2eae0c970da5b25bee32a280b48.tar.gz bcm5719-llvm-e588b8b66456e2eae0c970da5b25bee32a280b48.zip |
DWARFExpression: Simplify class interface
Summary:
The DWARFExpression methods have a lot of arguments. This removes two of
them by removing the ability to slice the expression via two offset+size
parameters. This is a functionality that it is not always needed, and
when it is, we already have a different handy way of slicing a data
extractor which we can use instead.
Reviewers: JDevlieghere, clayborg
Subscribers: aprantl, lldb-commits
Differential Revision: https://reviews.llvm.org/D66745
llvm-svn: 370027
Diffstat (limited to 'lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp')
-rw-r--r-- | lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp b/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp index 3d8bfb05872..6aaff06cc13 100644 --- a/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp +++ b/lldb/source/Plugins/SymbolFile/NativePDB/DWARFLocationExpression.cpp @@ -122,7 +122,7 @@ static DWARFExpression MakeLocationExpressionInternal(lldb::ModuleSP module, DataBufferSP buffer = std::make_shared<DataBufferHeap>(stream.GetData(), stream.GetSize()); DataExtractor extractor(buffer, byte_order, address_size, byte_size); - DWARFExpression result(module, extractor, nullptr, 0, buffer->GetByteSize()); + DWARFExpression result(module, extractor, nullptr); result.SetRegisterKind(register_kind); return result; @@ -247,6 +247,6 @@ DWARFExpression lldb_private::npdb::MakeConstantLocationExpression( .take_front(size); buffer->CopyData(bytes.data(), size); DataExtractor extractor(buffer, lldb::eByteOrderLittle, address_size); - DWARFExpression result(nullptr, extractor, nullptr, 0, size); + DWARFExpression result(nullptr, extractor, nullptr); return result; } |