diff options
author | Adrian Prantl <aprantl@apple.com> | 2019-10-01 15:40:41 +0000 |
---|---|---|
committer | Adrian Prantl <aprantl@apple.com> | 2019-10-01 15:40:41 +0000 |
commit | bf9d84c0149b4944d58a00024c8abd98eefc9589 (patch) | |
tree | f9d2d3252890e476cbccc4870157536bae355f1c /lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp | |
parent | 3c912c4abe2bb962c7bddcf52fab6c65bc5899d5 (diff) | |
download | bcm5719-llvm-bf9d84c0149b4944d58a00024c8abd98eefc9589.tar.gz bcm5719-llvm-bf9d84c0149b4944d58a00024c8abd98eefc9589.zip |
Remove size_t return parameter from FindTypes
In r368345 I accidentally introduced a regression that would
over-report the number of matches found by FindTypes if the
DeclContext Filter was hit.
This patch simply removes the size_t return parameter altogether —
it's not that useful.
rdar://problem/55500457
Differential Revision: https://reviews.llvm.org/D68169
llvm-svn: 373344
Diffstat (limited to 'lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp')
-rw-r--r-- | lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp index 1a15abcf20f..e80bf594e4a 100644 --- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp +++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp @@ -151,8 +151,8 @@ TypeSP DWARFASTParserClang::ParseTypeFromDWO(const DWARFDIE &die, Log *log) { // The type in the Clang module must have the same langage as the current CU. LanguageSet languages; languages.Insert(die.GetCU()->GetLanguageType()); - if (!dwo_module_sp->GetSymbolFile()->FindTypes(decl_context, languages, - dwo_types)) { + dwo_module_sp->GetSymbolFile()->FindTypes(decl_context, languages, dwo_types); + if (dwo_types.GetSize()) { if (!IsClangModuleFwdDecl(die)) return TypeSP(); @@ -162,8 +162,9 @@ TypeSP DWARFASTParserClang::ParseTypeFromDWO(const DWARFDIE &die, Log *log) { for (const auto &name_module : sym_file.getExternalTypeModules()) { if (!name_module.second) continue; - if (name_module.second->GetSymbolFile()->FindTypes(decl_context, - languages, dwo_types)) + name_module.second->GetSymbolFile()->FindTypes(decl_context, + languages, dwo_types); + if (dwo_types.GetSize()) break; } } |