diff options
author | Sam McCall <sam.mccall@gmail.com> | 2019-07-24 12:14:56 +0000 |
---|---|---|
committer | Sam McCall <sam.mccall@gmail.com> | 2019-07-24 12:14:56 +0000 |
commit | bdc6b6e410114295fc80a6ac7d8784681fed39c7 (patch) | |
tree | 56d51961b5aee094145535addfb6cf088b73a622 /lldb/source/Plugins/ScriptInterpreter/Python | |
parent | aaad1a8959d05718fa44c10122ba0ce4d7d3935c (diff) | |
download | bcm5719-llvm-bdc6b6e410114295fc80a6ac7d8784681fed39c7.tar.gz bcm5719-llvm-bdc6b6e410114295fc80a6ac7d8784681fed39c7.zip |
[clangd] SelectionTree treats TranslationUnitDecl (mostly) consistently with other containers.
Summary:
Previously TranslationUnitDecl would never be selected.
This means root() is never null, and returns a reference.
commonAncestor() is in principle never null also, but returning TUDecl
here requires tweaks to be careful not to traverse it (this was already
possible when selecting multiple top-level decls, and there are associated bugs!)
Instead, never allow commonAncestor() to return TUDecl, return null instead.
Reviewers: hokein
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D65101
llvm-svn: 366893
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python')
0 files changed, 0 insertions, 0 deletions