diff options
| author | Jordan Rupprecht <rupprecht@google.com> | 2019-10-17 21:55:43 +0000 |
|---|---|---|
| committer | Jordan Rupprecht <rupprecht@google.com> | 2019-10-17 21:55:43 +0000 |
| commit | 98a2ae7dadf897305e1cc2d9a5d63edf925c07f7 (patch) | |
| tree | e54cb59d119529e95bea30ef851486739d494727 /lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h | |
| parent | 6caada4eb4654783a45f6ae7bb1cd0eebcf4b0bb (diff) | |
| download | bcm5719-llvm-98a2ae7dadf897305e1cc2d9a5d63edf925c07f7.tar.gz bcm5719-llvm-98a2ae7dadf897305e1cc2d9a5d63edf925c07f7.zip | |
Reland [llvm-objdump] Use a counter for llvm-objdump -h instead of the section index.
This relands r374931 (reverted in r375088). It fixes 32-bit builds by using the right format string specifier for uint64_t (PRIu64) instead of `%d`.
Original description:
When listing the index in `llvm-objdump -h`, use a zero-based counter instead of the actual section index (e.g. shdr->sh_index for ELF).
While this is effectively a noop for now (except one unit test for XCOFF), the index values will change in a future patch that filters certain sections out (e.g. symbol tables). See D68669 for more context. Note: the test case in `test/tools/llvm-objdump/X86/section-index.s` already covers the case of incrementing the section index counter when sections are skipped.
Reviewers: grimar, jhenderson, espindola
Reviewed By: grimar
Subscribers: emaste, sbc100, arichardson, aheejin, arphaman, seiya, llvm-commits, MaskRay
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68848
llvm-svn: 375178
Diffstat (limited to 'lldb/source/Plugins/ScriptInterpreter/Python/PythonDataObjects.h')
0 files changed, 0 insertions, 0 deletions
