diff options
| author | Pavel Labath <pavel@labath.sk> | 2019-08-09 09:10:50 +0000 |
|---|---|---|
| committer | Pavel Labath <pavel@labath.sk> | 2019-08-09 09:10:50 +0000 |
| commit | af1744cd6e8a1435cfc68e99da22bb2d95f37de1 (patch) | |
| tree | dec407d5b0a371858768804092778237eed435aa /lldb/source/Plugins/Process | |
| parent | 4ef50a33b12825593a82ca8ea97158b7b71b348e (diff) | |
| download | bcm5719-llvm-af1744cd6e8a1435cfc68e99da22bb2d95f37de1.tar.gz bcm5719-llvm-af1744cd6e8a1435cfc68e99da22bb2d95f37de1.zip | |
Minidump/Windows: Fix module lookup
Summary:
When opening a minidump, we were failing to find an executable because
we were searching for i386-unknown-windows, whereas we recognize the
pe/coff files as i386-pc-windows. This fixes the triple computation code
in the minidump parser to match pe/coff, and adds an appropriate test.
NB: I'm not sure setting the vendor to "pc" is really correct for
arm(64) windows, but right now that seems to match what we do in the
pe/coff case (ArchSpec.cpp:935).
Reviewers: clayborg, amccarth
Subscribers: javed.absar, kristof.beyls, rnk, markmentovai, lldb-commits
Differential Revision: https://reviews.llvm.org/D65955
llvm-svn: 368416
Diffstat (limited to 'lldb/source/Plugins/Process')
| -rw-r--r-- | lldb/source/Plugins/Process/minidump/MinidumpParser.cpp | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp b/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp index ff015aa54b7..e1e0f39bca1 100644 --- a/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp +++ b/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp @@ -188,6 +188,7 @@ ArchSpec MinidumpParser::GetArchitecture() { case OSPlatform::Win32NT: case OSPlatform::Win32CE: triple.setOS(llvm::Triple::OSType::Win32); + triple.setVendor(llvm::Triple::VendorType::PC); break; case OSPlatform::Linux: triple.setOS(llvm::Triple::OSType::Linux); |
