summaryrefslogtreecommitdiffstats
path: root/lldb/source/Plugins/Process
diff options
context:
space:
mode:
authorMartin Storsjö <martin@martin.st>2019-10-31 09:46:56 +0200
committerMartin Storsjö <martin@martin.st>2019-10-31 11:26:06 +0200
commita42967f63c96b30dd6873ceb7b2932eb7cf2cd05 (patch)
treefb461146bca4216b4634baf8aa472c399e789184 /lldb/source/Plugins/Process
parent7e1a3076419d4d453d71143a1e81409ea1db177c (diff)
downloadbcm5719-llvm-a42967f63c96b30dd6873ceb7b2932eb7cf2cd05.tar.gz
bcm5719-llvm-a42967f63c96b30dd6873ceb7b2932eb7cf2cd05.zip
[LLDB] [Windows] Remove a TODO which probably won't be implemented
Contrary to WoW64 on x86_64, there's no struct similar to WOW64_CONTEXT defined, for storing and handling the CPU state of an ARM32 process from an ARM64 process. Thus, making an ARM64 lldb-server able to control ARM32 processes seems infeasible at the moment. (The normal CONTEXT struct has a different layout on each architecture. In addition to this, a WOW64_CONTEXT struct always is defined, that can store the CPU state of an x86_32 process, to allow handling it from an x86_64 process. But there's no similar universally available struct for ARM32.)
Diffstat (limited to 'lldb/source/Plugins/Process')
-rw-r--r--lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp2
1 files changed, 0 insertions, 2 deletions
diff --git a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp
index d86c68c8b66..b3b3abf6898 100644
--- a/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp
+++ b/lldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows_arm64.cpp
@@ -135,8 +135,6 @@ static Status SetThreadContextHelper(lldb::thread_t thread_handle,
std::unique_ptr<NativeRegisterContextWindows>
NativeRegisterContextWindows::CreateHostNativeRegisterContextWindows(
const ArchSpec &target_arch, NativeThreadProtocol &native_thread) {
- // TODO: Register context for a WoW64 application?
-
// Register context for a native 64-bit application.
return std::make_unique<NativeRegisterContextWindows_arm64>(target_arch,
native_thread);
OpenPOWER on IntegriCloud