summaryrefslogtreecommitdiffstats
path: root/lldb/source/Plugins/Process/minidump
diff options
context:
space:
mode:
authorPavel Labath <pavel@labath.sk>2019-08-21 13:20:25 +0000
committerPavel Labath <pavel@labath.sk>2019-08-21 13:20:25 +0000
commitd139e8838a6efb8c0b6d6518c2608b253b1e9ee3 (patch)
tree25f049214fdc597b7f65f64b12e31f2ed4dc60e2 /lldb/source/Plugins/Process/minidump
parent65a376f091eaaed3c10b2c5c2dfb3c1a61fb996b (diff)
downloadbcm5719-llvm-d139e8838a6efb8c0b6d6518c2608b253b1e9ee3.tar.gz
bcm5719-llvm-d139e8838a6efb8c0b6d6518c2608b253b1e9ee3.zip
Recommit "Minidump/Windows: Fix module lookup""
This recommits r368416, which was reverted in r368838 because of test failures under ASAN. These have been dealt with by llvm r369370. The original commit message was: When opening a minidump, we were failing to find an executable because we were searching for i386-unknown-windows, whereas we recognize the pe/coff files as i386-pc-windows. This fixes the triple computation code in the minidump parser to match pe/coff, and adds an appropriate test. NB: I'm not sure setting the vendor to "pc" is really correct for arm(64) windows, but right now that seems to match what we do in the pe/coff case (ArchSpec.cpp:935). Reviewers: clayborg, amccarth Subscribers: javed.absar, kristof.beyls, rnk, markmentovai, lldb-commits Differential Revision: https://reviews.llvm.org/D65955 llvm-svn: 369523
Diffstat (limited to 'lldb/source/Plugins/Process/minidump')
-rw-r--r--lldb/source/Plugins/Process/minidump/MinidumpParser.cpp1
1 files changed, 1 insertions, 0 deletions
diff --git a/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp b/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
index ff015aa54b7..e1e0f39bca1 100644
--- a/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
+++ b/lldb/source/Plugins/Process/minidump/MinidumpParser.cpp
@@ -188,6 +188,7 @@ ArchSpec MinidumpParser::GetArchitecture() {
case OSPlatform::Win32NT:
case OSPlatform::Win32CE:
triple.setOS(llvm::Triple::OSType::Win32);
+ triple.setVendor(llvm::Triple::VendorType::PC);
break;
case OSPlatform::Linux:
triple.setOS(llvm::Triple::OSType::Linux);
OpenPOWER on IntegriCloud