diff options
| author | Pavel Labath <labath@google.com> | 2016-08-16 09:36:29 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2016-08-16 09:36:29 +0000 |
| commit | 5a123c4e37d9969a7c1a0d2b470db9330267817b (patch) | |
| tree | 9b3fae0bda330f212f043a1060207e7dcd472c75 /lldb/source/Plugins/Process/gdb-remote | |
| parent | 6cd8c9a9d684698a0a9140db22da8cd8a5f73f76 (diff) | |
| download | bcm5719-llvm-5a123c4e37d9969a7c1a0d2b470db9330267817b.tar.gz bcm5719-llvm-5a123c4e37d9969a7c1a0d2b470db9330267817b.zip | |
Remove GetThreadSuffixSupported from GDBRemoteCommunication **base** class
Despite its comment, the function is only used in the Client class, and its presence was merely
complicating mock implementation in unit tests.
llvm-svn: 278785
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote')
3 files changed, 1 insertions, 13 deletions
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h index 623f0d16653..5eb1f290168 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h @@ -126,12 +126,6 @@ public: } //------------------------------------------------------------------ - // Client and server must implement these pure virtual functions - //------------------------------------------------------------------ - virtual bool - GetThreadSuffixSupported () = 0; - - //------------------------------------------------------------------ // Set the global packet timeout. // // For clients, this is the timeout that gets used when sending diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h index 424a949a9ab..83502f4727e 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h @@ -65,7 +65,7 @@ public: std::string &response_string); bool - GetThreadSuffixSupported () override; + GetThreadSuffixSupported(); // This packet is usually sent first and the boolean return value // indicates if the packet was send and any response was received diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h index d2fd70042cc..7bb67263f3b 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.h @@ -176,12 +176,6 @@ protected: }); } - bool - GetThreadSuffixSupported () override - { - return true; - } - //------------------------------------------------------------------ /// Launch a process with the current launch settings. /// |
