diff options
author | Pavel Labath <labath@google.com> | 2015-07-28 09:06:56 +0000 |
---|---|---|
committer | Pavel Labath <labath@google.com> | 2015-07-28 09:06:56 +0000 |
commit | 424b201df7b3c86ba6981d6a46d22295494a52e3 (patch) | |
tree | 6b0debb64478b5df03788046b9007df74d59491a /lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp | |
parent | cba308cf9605e6097c5400f0214dc509997d51ab (diff) | |
download | bcm5719-llvm-424b201df7b3c86ba6981d6a46d22295494a52e3.tar.gz bcm5719-llvm-424b201df7b3c86ba6981d6a46d22295494a52e3.zip |
[LLGS] Avoid bogus error message on process termination
Summary:
Handle_k was printing an error when killing a process because KillSpawnedProcess was expecting to
be asynchronously notified of the process death, which no longer works, since we don't wait for
the process on a separate thread. However, the whole usage of KillSpawnedProcess is dubious here,
since it tries to be nice and terminate the process first with SIGTERM, which will not have the
intended effect on a ptraced process. I replace this code with a call to
NativeProcessProtocol::Kill, which does not suffer from these problems.
Reviewers: chaoren, ovyalov
Subscribers: lldb-commits
Differential Revision: http://reviews.llvm.org/D11520
llvm-svn: 243397
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp')
0 files changed, 0 insertions, 0 deletions