Revert "Implement xfer:libraries-svr4:read packet"

D62502, together with D62503 have broken the builds which have XML
support enabled. Reverting D62503 (r364355) fixed that, but has broken
has left some of the tests introduced by D62502 broken more or less
nondeternimistically (it depended on whether the system happens to place
the library list near unreadable pages of memory). I attempted to make a
partial fix for this in r364748, but Jan Kratochvil pointed out that
this reintroduces the problem which reverting D62503 was trying to
solve.

So instead, I back out the whole thing so we can get back to a clean
slate that works for everyone. We can figure out a way forward from
there.

This reverts r364748, r363772 and r363707.

llvm-svn: 364751

1 files changed, 0 insertions, 43 deletions

diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
index 190db341ae0..196607665bb 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
@@ -2765,24 +2765,6 @@ GDBRemoteCommunicationServerLLGS::ReadXferObject(llvm::StringRef object,
     return std::move(*buffer_or_error);
   }
 
-  if (object == "libraries-svr4") {
-    auto library_list = m_debugged_process_up->GetLoadedSVR4Libraries();
-    if (!library_list)
-      return library_list.takeError();
-
-    StreamString response;
-    response.Printf("<library-list-svr4 version=\"1.0\">");
-    for (auto const &library : *library_list) {
-      response.Printf("<library name=\"%s\" ",
-                      XMLEncodeAttributeValue(library.name.c_str()).c_str());
-      response.Printf("lm=\"0x%" PRIx64 "\" ", library.link_map);
-      response.Printf("l_addr=\"0x%" PRIx64 "\" ", library.base_addr);
-      response.Printf("l_ld=\"0x%" PRIx64 "\" />", library.ld_addr);
-    }
-    response.Printf("</library-list-svr4>");
-    return MemoryBuffer::getMemBufferCopy(response.GetString(), __FUNCTION__);
-  }
-
   return llvm::make_error<PacketUnimplementedError>(
       "Xfer object not supported");
 }
@@ -3301,28 +3283,3 @@ GDBRemoteCommunicationServerLLGS::FindModuleFile(const std::string &module_path,
 
   return GDBRemoteCommunicationServerCommon::FindModuleFile(module_path, arch);
 }
-
-std::string GDBRemoteCommunicationServerLLGS::XMLEncodeAttributeValue(
-    llvm::StringRef value) {
-  std::string result;
-  for (const char &c : value) {
-    switch (c) {
-    case '\'':
-      result += "&apos;";
-      break;
-    case '"':
-      result += "&quot;";
-      break;
-    case '<':
-      result += "&lt;";
-      break;
-    case '>':
-      result += "&gt;";
-      break;
-    default:
-      result += c;
-      break;
-    }
-  }
-  return result;
-}
\ No newline at end of file