summaryrefslogtreecommitdiffstats
path: root/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
diff options
context:
space:
mode:
authorFrancis Ricci <francisjricci@gmail.com>2016-04-25 20:59:11 +0000
committerFrancis Ricci <francisjricci@gmail.com>2016-04-25 20:59:11 +0000
commit39f1189acbf6922b7fe90e8de80f58caaabfde53 (patch)
treeb77ea70b09f81644f841ac1112ab9322de046995 /lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
parentabe2d016cf9e1e1ffefdc0cce03e125bec811493 (diff)
downloadbcm5719-llvm-39f1189acbf6922b7fe90e8de80f58caaabfde53.tar.gz
bcm5719-llvm-39f1189acbf6922b7fe90e8de80f58caaabfde53.zip
Use Process Plugin register indices when communicating with remote
Summary: eRegisterKindProcessPlugin is used to store the register indices used by the remote, and eRegisterKindLLDB is used to store the internal lldb register indices. However, we're currently using the lldb indices instead of the process plugin indices when sending p/P packets. This will break if the remote uses non-contiguous register indices. Reviewers: jasonmolenda, clayborg Subscribers: lldb-commits, sas Differential Revision: http://reviews.llvm.org/D19305 llvm-svn: 267466
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h')
-rw-r--r--lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
index 311b0f3267c..33114d2611f 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
@@ -527,7 +527,7 @@ public:
bool
ReadRegister(lldb::tid_t tid,
- uint32_t reg_num,
+ uint32_t reg_num, // Must be the eRegisterKindProcessPlugin register number, to be sent to the remote
StringExtractorGDBRemote &response);
bool
OpenPOWER on IntegriCloud