diff options
| author | Pavel Labath <labath@google.com> | 2017-02-17 11:48:34 +0000 |
|---|---|---|
| committer | Pavel Labath <labath@google.com> | 2017-02-17 11:48:34 +0000 |
| commit | a37bbbd43203eb383172e216ce7a979fe7f6e9e8 (patch) | |
| tree | 9123810b91492c45baa7c5b28fd62debf1309877 /lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp | |
| parent | 7cab0786bdcca1300cf9150788d3b1f5abd9923c (diff) | |
| download | bcm5719-llvm-a37bbbd43203eb383172e216ce7a979fe7f6e9e8.tar.gz bcm5719-llvm-a37bbbd43203eb383172e216ce7a979fe7f6e9e8.zip | |
NPL: Fix one more bug in the single step workaround
In the case we are stepping over the thread creation instruction, we
will end up calling Thread::SingleStep back-to-back twice (because of
the intermediate PTRACE_EVENT_CLONE stop). This will cause the cpu mask
to be set inappropriately (because the old SingleStepCheck object will
be destroyed after we create the new one), and the single-step will
fail.
Before the refactor the code was still incorrect in this case, but in a
different way (the thread was left with the incorrect mask after the
stepping was complete), so this was not easy to spot.
This fixes TestCreateDuringInstructionStep on the affected devices.
llvm-svn: 295440
Diffstat (limited to 'lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp')
0 files changed, 0 insertions, 0 deletions
