Fixed an issue in GDBRemoteCommunicationClient where we weren't listening to

the "payload_length" argument for the "payload" packet data. This meant we 
could end up sending random extra data with a packet depending on how the 
packet was constructed.

Fixed GDBRemoteRegisterContext to properly save and restore all registers. 
Previous fixes had been added to work around the "payload_length" issues fixed
above and aren't needed anymore.

Fix logging in GDBRemoteCommunication to make sure we log the correct packet
data being sent by using the packet length when dumping the packet contents.

Added register definitions for 'arm-lldb' in the "disasm-gdb-remote.pl" script
so if you have a register dump from the GDB remote that doesn't include the
qRegisterInfo packets, you can manually tell the script which registers are
which.

llvm-svn: 131715

1 files changed, 3 insertions, 3 deletions

diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
index bfb4755931b..314d51f55aa 100644
--- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
+++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
@@ -252,7 +252,7 @@ GDBRemoteCommunicationClient::SendPacketAndWaitForResponse
 
     if (GetSequenceMutex (locker))
     {
-        if (SendPacketNoLock (payload, strlen(payload)))
+        if (SendPacketNoLock (payload, payload_length))
             return WaitForPacketNoLock (response, &timeout_time);
     }
     else
@@ -1597,8 +1597,8 @@ GDBRemoteCommunicationClient::GetThreadStopInfo (uint32_t tid, StringExtractorGD
             m_supports_qThreadStopInfo = false;
         }
     }
-    if (SetCurrentThread (tid))
-        return GetStopReply (response);
+//    if (SetCurrentThread (tid))
+//        return GetStopReply (response);
     return false;
 }